Skip to content

build: run Travis against Linux and OS X #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
strawbrary wants to merge 8 commits into from
Closed

build: run Travis against Linux and OS X #288

strawbrary wants to merge 8 commits into from

Conversation

@strawbrary
Copy link
Contributor

@strawbrary strawbrary commented Apr 27, 2016

No description provided.

@strawbrary strawbrary mentioned this pull request Apr 27, 2016
Closed
@strawbrary
Copy link
Contributor Author

strawbrary commented Apr 27, 2016 •
edited
Loading

Got the repro for #272!

@benmosher
Copy link
Member

benmosher commented Apr 27, 2016

Ah, sweet! I didn't realize it was that simple.

Can you rebase this commit against the node-v6 branch? I think I've got it fixed over there so all the tests should pass, then I can merge this in.

@strawbrary
Copy link
Contributor Author

strawbrary commented Apr 27, 2016

Done!

@benmosher
Copy link
Member

benmosher commented Apr 28, 2016

Thanks! though I didn't realize a few commits from master had snuck in, so I just cherry-picked the OS commit over to #273.

@benmosher benmosher closed this Apr 28, 2016
This was referenced Apr 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strawbrary @benmosher @jquense