Limit line length in src/briefcase comments (ruff E501)#2526
Merged
freakboy3742 merged 1 commit intobeeware:mainfrom Oct 22, 2025
Merged
Limit line length in src/briefcase comments (ruff E501)#2526freakboy3742 merged 1 commit intobeeware:mainfrom
src/briefcase comments (ruff E501)#2526freakboy3742 merged 1 commit intobeeware:mainfrom
Conversation
freakboy3742
approved these changes
Oct 22, 2025
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Incremental improvement is still improvement; If this gets us ~100 issues closer to being able to enable E501, then it's worth it.
I'd suggest a similar incremental approach is worthwhile for the code changes as well - a PR that fixes "all line lengths in the platform module" (or similar) will make the review process a lot easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2383 requests to resolve ruff rule E501 by limiting all lines to 88 characters (and probably adding some
noqacomments).I'd like to split it into multiple PRs because it is a large task and the resolutions might trigger some (justified) discussions around style preferences.
This PR only addresses the comments in
src/briefcase, which reduces the number of violations from 520 to 446. Please let me know what you think, and if you are interested in more PRs like this.(I started with comments because I assume these fixes are less controversial than actual code changes.)
Refs #2383
PR Checklist: