Conversation
|
@freakboy3742 This is ready for review. Notes:
|
freakboy3742
left a comment
There was a problem hiding this comment.
tl;dr - this looks great, and is really close to being mergable; as with Toga, I'd rather merge this early and fix any minor issues that are found rather than try to keep it up to date while we get it perfect.
I've cleaned up a handful of things that I noticed that were easy cleanups; some bigger issues:
- Newline reflow - Toga converged on using line breaks only for paragraphs; that hasn't been applied here.
- iOS Permissions - 2nd level bullet points aren't being interpreted as indented
- Android icon formats - same bullet point issues
- The "Community details" page is still in the left-hand index (and exists as a page), but is duplicate on the homepage.
The only other thing that I noticed was the "hand crafted" table format. I understand why that's been done, and I can live with merging as is. However, it's worth flagging as follow up work that the work @HalfWhitt has done in the Toga docs to clean up tables could be used here as well.
|
The tables are terrible, yes. I agree the Toga updates would be useful here. Everything else should be good to go. |
freakboy3742
left a comment
There was a problem hiding this comment.
Looks good to me!
Marking as accepted. Given the size of the change, I'd like @mhsmith to sign off as well before merging; but I think the same approach makes sense here as did with Toga - it's better to merge somethign on latest that has some known issues and resolve those piecemeal, rather than try to maintain this as a branch until we know it's perfect.
|
Thanks, that all looks good, but unfortunately there's one last conflict from #2496 that will need to be resolved. |
I've just merged and fixed that one. |
mhsmith
left a comment
There was a problem hiding this comment.
OK, I'm finished for the day now, but consider it approved once the build works and the post-install docs render correctly.
Well done!
Getting this going for testing purposes.
Fixes #2387
PR Checklist: