Avoid passing config fields as flags for pnpm

bcomnes · bcomnes · commit dc2d7da61cf0 · 2024-09-13T14:45:23.000-07:00
Matching the behavior with yarn, stop npm-run-all2 from passing fields in the package.json#config field as flags.
diff --git a/lib/run-task.js b/lib/run-task.js
@@ -192,13 +192,15 @@ module.exports = function runTask (task, options) {
     }
 
     const isYarn = process.env.npm_config_user_agent && process.env.npm_config_user_agent.startsWith('yarn')
+    const isPnpm = Boolean(process.env.PNPM_SCRIPT_SRC_DIR)
+    const isNpm = !isYarn && !isPnpm
 
     const spawnArgs = ['run']
 
     if (npmPathIsJs) {
       spawnArgs.unshift(npmPath)
     }
-    if (!isYarn) {
+    if (isNpm) {
       Array.prototype.push.apply(spawnArgs, options.prefixOptions)
     } else if (options.prefixOptions.indexOf('--silent') !== -1) {
       spawnArgs.push('--silent')

Original file line number	Diff line number	Diff line change
`@@ -192,13 +192,15 @@ module.exports = function runTask (task, options) {`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`const isYarn = process.env.npm_config_user_agent && process.env.npm_config_user_agent.startsWith('yarn')`
	`195`	`+ const isPnpm = Boolean(process.env.PNPM_SCRIPT_SRC_DIR)`
	`196`	`+ const isNpm = !isYarn && !isPnpm`
`195`	`197`
`196`	`198`	`const spawnArgs = ['run']`
`197`	`199`
`198`	`200`	`if (npmPathIsJs) {`
`199`	`201`	`spawnArgs.unshift(npmPath)`
`200`	`202`	`}`
`201`		`- if (!isYarn) {`
	`203`	`+ if (isNpm) {`
`202`	`204`	`Array.prototype.push.apply(spawnArgs, options.prefixOptions)`
`203`	`205`	`} else if (options.prefixOptions.indexOf('--silent') !== -1) {`
`204`	`206`	`spawnArgs.push('--silent')`