Add a discover_tests attribute to swift_test
#1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Jun 21, 2024
This attribute, which is `True` by default, controls whether `XCTest`-style tests are automatically discovered (either using the Objective-C runtime or manual discovery via symbol graphs). If set to `False`, the test is assumed to provide its own `main`. This will subsume the behavior of the `swift.bundled_xctests` feature, which will be removed in the future. PiperOrigin-RevId: 471589475
brentleyjones
force-pushed
the
bj/add-a-discover_tests-attribute-to-swift_test
branch
2 times, most recently
from
ed0ab66 to
2a4b01b
Compare
This attribute, which is `True` by default, controls whether `XCTest`-style tests are automatically discovered (either using the Objective-C runtime or manual discovery via symbol graphs). If set to `False`, the test is assumed to provide its own `main`. This will subsume the behavior of the `swift.bundled_xctests` feature, which will be removed in the future. PiperOrigin-RevId: 471589475 (cherry picked from commit 477b48a) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/add-a-discover_tests-attribute-to-swift_test
branch
from
2a4b01b to
da193cb
Compare
thii
approved these changes
Jun 22, 2024
brentleyjones
deleted the
bj/add-a-discover_tests-attribute-to-swift_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute, which is
Trueby default, controls whetherXCTest-style tests are automatically discovered (either using the Objective-C runtime or manual discovery via symbol graphs). If set toFalse, the test is assumed to provide its ownmain.This will subsume the behavior of the
swift.bundled_xctestsfeature, which will be removed in the future.PiperOrigin-RevId: 471589475
(cherry picked from commit 477b48a)