Skip to content

Conversation

@meteorcloudy
Copy link
Member

Fixing re2 in #6402

@bazel-io
Copy link
Member

Hello @rsc, modules you maintain (re2) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new version 2025-11-05.bcr.1 for the re2 module to provide compatibility with Bazel 9. The changes correctly follow the add-only policy of the Bazel Central Registry and include all the necessary files. My review found one issue: the presubmit configuration for the test module (bcr_test_module) is missing Bazel 9 from its test matrix. To ensure full compatibility, it's important that the module's own tests are executed against Bazel 9.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 26, 2025
@kotlaja kotlaja merged commit 4d5eab8 into bazelbuild:main Nov 27, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants