-
Notifications
You must be signed in to change notification settings - Fork 604
Add brotli 1.2.0 and brotli_go 1.2.0 #6618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @eustas, modules you maintain (brotli_go) have been updated in this PR. |
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (brotli) have been updated in this PR. |
4ce5a0d to
2907bfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds version 1.2.0 for the brotli and brotli_go modules. The changes are mostly well-structured and follow the Bazel Central Registry guidelines. I've found one critical issue in the MODULE.bazel for brotli_go that will likely cause presubmit failures.
Additionally, the maintainers field for the brotli module has been updated in modules/brotli/metadata.json. As per the BCR style guide, significant changes to maintainers require a manual review. @bazelbuild/bcr-maintainers, please review this change.
Please see the detailed comment for the fix.
|
@bazel-io skip_check unstable_url |
ab39c2b to
cd4085d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like MODULE.bazel was not included in https://github.com/google/brotli/archive/refs/tags/v1.2.0.tar.gz
ef48635 to
5a18f7f
Compare
| - macos | ||
| - macos_arm64 | ||
| bazel: | ||
| - 8.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also want to test the upcoming Bazel 9? Add 9.* here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ready for 9.*
3ba059e to
88509c1
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
88509c1 to
ac72708
Compare
Description
Provide recent 1.2.0 version
/cc @eustas