Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Provide recent 1.2.0 version

/cc @eustas

@google-cla
Copy link

google-cla bot commented Nov 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bazel-io
Copy link
Member

Hello @eustas, modules you maintain (brotli_go) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (brotli) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.2.0 for the brotli and brotli_go modules. The changes are mostly well-structured and follow the Bazel Central Registry guidelines. I've found one critical issue in the MODULE.bazel for brotli_go that will likely cause presubmit failures.

Additionally, the maintainers field for the brotli module has been updated in modules/brotli/metadata.json. As per the BCR style guide, significant changes to maintainers require a manual review. @bazelbuild/bcr-maintainers, please review this change.

Please see the detailed comment for the fix.

@mmorel-35
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 23, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotlaja kotlaja added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 24, 2025
- macos
- macos_arm64
bazel:
- 8.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to test the upcoming Bazel 9? Add 9.* here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ready for 9.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants