Skip to content

[email protected] #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #6614

wants to merge 1 commit into from
+117 −0

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Nov 22, 2025 •
edited
Loading

Removes LGPL files from hdrs, by reverting the BUILD file to match [email protected].

Closes #6589.

Amends #6148.

@jwnimmer-tri
[email protected]
142d5c6 
Removes LGPL files from hdrs, by reverting the BUILD file to match
3.4.0.bcr.3.
@bazel-io
Copy link
Member

bazel-io commented Nov 22, 2025

Hello @lalten, modules you maintain (eigen) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review November 22, 2025 15:18
@jwnimmer-tri jwnimmer-tri mentioned this pull request Nov 22, 2025
Open
@jwnimmer-tri
Copy link
Contributor Author

jwnimmer-tri commented Nov 22, 2025

Huh, it seems "bazel rolling" is intrinsically broken with some unrelated Java thing, maybe bazelbuild/bazel#27749?

bazel-io
bazel-io approved these changes Nov 22, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@Vertexwahn
Copy link
Contributor

Vertexwahn commented Nov 22, 2025

Yes rolling version is currently broken - I recommend to wait until a new rolling release is published (seems to be something that takes few days - max 25 days)

@jwnimmer-tri
Copy link
Contributor Author

jwnimmer-tri commented Nov 24, 2025

Is there a presubmit syntax to check 9.x rc's instead of "rolling". It seems a bit premature to be testing against Bazel 10, especially for a small bugfix patch release.

@martis42
Copy link
Contributor

martis42 commented Nov 25, 2025

@jwnimmer-tri You can test against the Bazel 9 release candidates with 9.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazel-io bazel-io bazel-io approved these changes

+1 more reviewer

@lalten lalten lalten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: eigen 3.4.1 exposes LGPL files

5 participants

@jwnimmer-tri @bazel-io @Vertexwahn @martis42 @lalten