Skip to content

Conversation

@matthias-giersch
Copy link
Contributor

Adds fpm version 1.1.0 (https://github.com/MikeLankamp/fpm) to BCR.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (fpm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the fpm module at version 1.1.0 to the Bazel Central Registry. The overall structure and configuration align well with BCR practices, including the use of an overlay for this header-only C++ library and a comprehensive presubmit matrix. However, there are a couple of critical typos in the metadata.json file for the homepage and repository URLs that need to be corrected.

@matthias-giersch
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 20, 2025
- ubuntu2204
bazel:
- 7.x
- 8.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add - rolling to make sure the thing works with upcoming Bazel 9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, thank's

@@ -0,0 +1,8 @@
cc_library(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to a load statement for cc_library (otherwise Bazel 9 will not work)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildifier -lint=fix -r .

@UebelAndre
Copy link
Contributor

For what it's worth the name seems to conflict with https://github.com/jordansissel/fpm which is what I hoped this was 😅

@Vertexwahn
Copy link
Contributor

I think that would be rules_fpm? So I assume fpm is fine here. Nevertheless, first come first served :) - and there is still the possibility of creating an own registry, overriding, prefixing with repo orga, alias magic, etc. - not sure what happens when two registry's are used that offer a module with the same name, but different contents and those are also used in transitive dependencies...

@UebelAndre
Copy link
Contributor

Nevertheless, first come first served :)

I don't think that's the case. I know a name change has been requested for tiny libraries mirroring the wider known one and when I Google "fpm" the one I linked is the number one result. I leave it up to @meteorcloudy to decide though and remove myself from the conversation

@Vertexwahn
Copy link
Contributor

Vertexwahn commented Nov 22, 2025

Some options for module names: mike_lankamp_fpm (to express it comes form this GitHub organisation), matthias_giersch_fpm (to express its your bazalization of fpm), your_company_fpm. Maybe to avoid such clashes and allow different bazelizations of the same library/module it would make sense that each module has also an "organisation" attribute. In the case someone is not happy with something (e.g. dispute which alias, tools, granularity) different versions can be offered - but do be honest for now would just name it differntly cpp_fpm, etc. and everyone is happy...

@matthias-giersch
Copy link
Contributor Author

Thank's both of you for the feedback and the input. I will rename it to cpp_fpm now.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cpp_fpm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 24, 2025
@UebelAndre
Copy link
Contributor

To further bike-shed, could call it fixed_point_math 😄

per:

A C++ header-only fixed-point math library. "fpm" stands for "fixed-point math".

Again, I personally wouldn't care if you went with fpm, I was just passing by and decided to share an unsolicited opinion 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants