Skip to content

Conversation

@pcj
Copy link
Member

@pcj pcj commented Nov 20, 2025

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (stackb_rules_closure) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the stackb_rules_closure module at version 1.0.0. The submission largely follows the Bazel Central Registry guidelines. However, there is a significant concern regarding the use of http_file and platform_http_file to download pre-built binaries, including platform-specific Debian packages. This practice is discouraged as it compromises cross-platform compatibility and reproducibility. My review includes a detailed comment on this issue with suggestions for improvement.

@keith keith added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 20, 2025
keith
keith previously approved these changes Nov 20, 2025
@pcj pcj force-pushed the stackb_rules_closure-v1.0.0 branch from 59d75c7 to d9e97eb Compare November 20, 2025 01:27
@bazel-io bazel-io dismissed keith’s stale review November 20, 2025 01:28

Require module maintainers' approval for newly pushed changes.

@pcj pcj force-pushed the stackb_rules_closure-v1.0.0 branch from d9e97eb to 4e5e8e6 Compare November 20, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants