Run buildifier to add explicit loads

fmeum · fmeum · commit 3d62171d485c · 2025-05-15T17:35:59.000+02:00
They will be required in Bazel 9.
diff --git a/go/private/context.bzl b/go/private/context.bzl
@@ -40,6 +40,7 @@ load(
     NOGO_EXCLUDES = "EXCLUDES",
     NOGO_INCLUDES = "INCLUDES",
 )
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
 load(
     "//go/platform:apple.bzl",
     "apple_ensure_options",
diff --git a/go/private/extensions.bzl b/go/private/extensions.bzl
@@ -228,7 +228,7 @@ def _go_sdk_impl(ctx):
                 if key not in ["go_mod"]
             }
             download_tag["version"] = version
-            additional_download_tags += [struct(**download_tag)]
+            additional_download_tags.append(struct(**download_tag))
 
         for index, download_tag in enumerate(module.tags.download + additional_download_tags):
             # SDKs without an explicit version are fetched even when not selected by toolchain
diff --git a/go/private/rules/binary.bzl b/go/private/rules/binary.bzl
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 load(
     "//go/private:common.bzl",
     "GO_TOOLCHAIN",
diff --git a/go/private/rules/cgo.bzl b/go/private/rules/cgo.bzl
@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 load(
     "//go/private:common.bzl",
     "get_versioned_shared_lib_extension",
diff --git a/go/private/rules/cross.bzl b/go/private/rules/cross.bzl
@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 load(
     "//go/private:providers.bzl",
     "GoArchive",
diff --git a/tests/bcr/BUILD.bazel b/tests/bcr/BUILD.bazel
@@ -7,6 +7,7 @@ load(
     "go_test",
     "nogo",
 )
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load("//:transition.bzl", "sdk_transition_test")
 
 nogo(
diff --git a/tests/bcr/proto/BUILD.bazel b/tests/bcr/proto/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
 load("@my_rules_go//go:def.bzl", "go_test")
 load("@my_rules_go//proto:def.bzl", "go_grpc_library", "go_proto_library")
 
diff --git a/tests/core/c_linkmodes/BUILD.bazel b/tests/core/c_linkmodes/BUILD.bazel
@@ -1,4 +1,7 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_binary")
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+load("@rules_cc//cc:cc_test.bzl", "cc_test")
 
 go_binary(
     name = "adder_archive",
diff --git a/tests/core/cgo/BUILD.bazel b/tests/core/cgo/BUILD.bazel
@@ -1,5 +1,8 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test")
 load("@io_bazel_rules_go//go/tools/bazel_testing:def.bzl", "go_bazel_test")
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_import.bzl", "cc_import")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
 package(
     # go_* rules do not emit module maps.
diff --git a/tests/core/cgo/objc/BUILD.bazel b/tests/core/cgo/objc/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@rules_cc//cc:objc_library.bzl", "objc_library")
 
 go_test(
     name = "objc_test",
diff --git a/tests/core/go_library/BUILD.bazel b/tests/core/go_library/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("//go:def.bzl", "go_binary", "go_library", "go_source", "go_test")
 load("//go/tools/bazel_testing:def.bzl", "go_bazel_test")
 load(":def.bzl", "embedsrcs_files")
diff --git a/tests/core/go_plugin_with_proto_library/BUILD.bazel b/tests/core/go_plugin_with_proto_library/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
 load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_test")
 load("@io_bazel_rules_go//proto:def.bzl", "go_proto_library")
 
diff --git a/tests/core/go_proto_aspect/codegen.bzl b/tests/core/go_proto_aspect/codegen.bzl
@@ -1,5 +1,5 @@
 load("@bazel_skylib//lib:paths.bzl", "paths")
-load("@io_bazel_rules_go//go:def.bzl", "GoArchive", "GoInfo", "go_context", "new_go_info")
+load("@io_bazel_rules_go//go:def.bzl", "go_context", "new_go_info")
 
 def _go_generated_library_impl(ctx):
     src = ctx.actions.declare_file("generated.go")
diff --git a/tests/examples/executable_name/BUILD.bazel b/tests/examples/executable_name/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_binary")
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 
 go_binary(
     name = "some_binary",
diff --git a/tests/legacy/cgo_select/BUILD.bazel b/tests/legacy/cgo_select/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
 go_library(
     name = "go_default_library",
diff --git a/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel b/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel
@@ -1,3 +1,7 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_import.bzl", "cc_import")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 cc_library(
     name = "version",
     srcs = ["cxx_version.cc"],
diff --git a/tests/legacy/examples/cgo/example_command/BUILD.bazel b/tests/legacy/examples/cgo/example_command/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_binary")
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load(":generate_test.bzl", "generate_script")
 
 package(
diff --git a/tests/legacy/extldflags_rpath/BUILD.bazel b/tests/legacy/extldflags_rpath/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_binary")
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 
 go_binary(
     name = "extldflags_rpath",
diff --git a/tests/legacy/info/BUILD.bazel b/tests/legacy/info/BUILD.bazel
@@ -1,3 +1,5 @@
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
+
 sh_test(
     name = "info",
     srcs = ["info_test.sh"],
diff --git a/tests/legacy/providers/BUILD.bazel b/tests/legacy/providers/BUILD.bazel
@@ -1,3 +1,4 @@
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load("//go:def.bzl", "go_source")
 load("//tests/legacy/providers:test.bzl", "test_source")
 
diff --git a/tests/legacy/transitive_data/BUILD.bazel b/tests/legacy/transitive_data/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
 go_test(
     name = "go_default_test",

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ load(`
`40`	`40`	`NOGO_EXCLUDES = "EXCLUDES",`
`41`	`41`	`NOGO_INCLUDES = "INCLUDES",`
`42`	`42`	`)`
	`43`	`+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")`
`43`	`44`	`load(`
`44`	`45`	`"//go/platform:apple.bzl",`
`45`	`46`	`"apple_ensure_options",`
Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ def _go_sdk_impl(ctx):`
`228`	`228`	`if key not in ["go_mod"]`
`229`	`229`	`}`
`230`	`230`	`download_tag["version"] = version`
`231`		`- additional_download_tags += [struct(**download_tag)]`
	`231`	`+ additional_download_tags.append(struct(**download_tag))`
`232`	`232`
`233`	`233`	`for index, download_tag in enumerate(module.tags.download + additional_download_tags):`
`234`	`234`	`# SDKs without an explicit version are fetched even when not selected by toolchain`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ load(`
`7`	`7`	`"go_test",`
`8`	`8`	`"nogo",`
`9`	`9`	`)`
	`10`	`+load("@rules_shell//shell:sh_test.bzl", "sh_test")`
`10`	`11`	`load("//:transition.bzl", "sdk_transition_test")`
`11`	`12`
`12`	`13`	`nogo(`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")`
`1`	`2`	`load("@my_rules_go//go:def.bzl", "go_test")`
`2`	`3`	`load("@my_rules_go//proto:def.bzl", "go_grpc_library", "go_proto_library")`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")`
	`2`	`+load("@rules_cc//cc:objc_library.bzl", "objc_library")`
`2`	`3`
`3`	`4`	`go_test(`
`4`	`5`	`name = "objc_test",`