Respect keys everywhere

barneycarroll · web-flow · commit c573ceb48f34 · 2017-03-18T10:04:58.000Z
Attempt to fix MithrilJS#1713, superseding MithrilJS#1720, as per @pygy's insight here MithrilJS#1720 (comment)
diff --git a/render/render.js b/render/render.js
@@ -233,7 +233,7 @@ module.exports = function($window) {
 	}
 	function updateNode(parent, old, vnode, hooks, nextSibling, recycling, ns) {
 		var oldTag = old.tag, tag = vnode.tag
-		if (oldTag === tag) {
+		if (oldTag === tag && vnode.key === old.key) {
 			vnode.state = old.state
 			vnode.events = old.events
 			if (!recycling && shouldNotUpdate(vnode, old)) return

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ module.exports = function($window) {`
`233`	`233`	`}`
`234`	`234`	`function updateNode(parent, old, vnode, hooks, nextSibling, recycling, ns) {`
`235`	`235`	`var oldTag = old.tag, tag = vnode.tag`
`236`		`- if (oldTag === tag) {`
	`236`	`+ if (oldTag === tag && vnode.key === old.key) {`
`237`	`237`	`vnode.state = old.state`
`238`	`238`	`vnode.events = old.events`
`239`	`239`	`if (!recycling && shouldNotUpdate(vnode, old)) return`