beforeCreate in a through table doesn't seem to work

[GeorgeSapkin]

I'm trying to use Waterline directly to simplify tests, but it seems like beforeCreate is not working in through tables. Here's some sample code reproducing the issue:

'use strict';

const memoryAdapter = require('sails-memory');
const Waterline     = require('waterline');

const User = {
    identity:   'user',
    connection: 'memory',

    attributes: {
        name: 'string',
        generated: 'integer',

        devices: {
            collection: 'device',
            through:    'deviceuser'
        }
    },

    beforeCreate(user, next) {
        console.log('user.beforeCreate');
        user.generated = 100;
        next();
    },
};

const Device = {
    identity:   'device',
    connection: 'memory',

    attributes: {
        name: 'string',
        generated: 'integer',

        users: {
            collection: 'user',
            through:    'deviceuser'
        }
    },

    beforeCreate(device, next) {
        console.log('device.beforeCreate');
        device.generated = 200;
        next();
    },
};

const DeviceUser = {
    identity:   'deviceuser',
    connection: 'memory',

    attributes: {
        device: {
            model: 'device',
            via:   'users',
        },

        user: {
            model: 'user',
            via:   'devices'
        },

        generated: 'integer'
    },

    beforeCreate(device, next) {
        console.log('deviceuser.beforeCreate');
        device.generated = 300;
        next();
    },
};

const waterline = new Waterline();
waterline.loadCollection(Waterline.Collection.extend(User));
waterline.loadCollection(Waterline.Collection.extend(Device));
waterline.loadCollection(Waterline.Collection.extend(DeviceUser));

const config = {
    adapters: {
        'default': memoryAdapter,
        memory:    memoryAdapter
    },
    connections: {
        memory: { adapter: 'memory' }
    },
};

waterline.initialize(config, (err, models) => {
    for (const cb of models.collections.user._callbacks.beforeCreate)
        console.log(cb.toString());
    for (const cb of models.collections.device._callbacks.beforeCreate)
        console.log(cb.toString());
    // DeviceUser.beforeCreate already gone
    for (const cb of models.collections.deviceuser._callbacks.beforeCreate)
        console.log(cb.toString());

    models.collections.user.create({ name: 'John Doe' })
        .then(console.log)
        .then(_ => models.collections.device.create({ name: 'Thing 3000' }))
        .then(console.log)
        .then(_ => models.collections.deviceuser.create({ device: 1, user: 1 }))
        .then(console.log);
});

Output:

beforeCreate(user, next) {
        console.log('user.beforeCreate');
        user.generated = 100;
        next();
    }
beforeCreate(device, next) {
        console.log('device.beforeCreate');
        device.generated = 200;
        next();
    }
function (values, next) { return next(); }
user.beforeCreate
{ name: 'John Doe',
  generated: 100,
  createdAt: '2015-11-13T22:16:06.105Z',
  updatedAt: '2015-11-13T22:16:06.105Z',
  id: 1 }
device.beforeCreate
{ name: 'Thing 3000',
  generated: 200,
  createdAt: '2015-11-13T22:16:06.119Z',
  updatedAt: '2015-11-13T22:16:06.119Z',
  id: 1 }
{ device: 1, user: 1, id: 1 }

As you can see DeviceUser.beforeCreate is replaced with a default stub and is never triggered.

Waterline version 0.10.26

[devinivy]

I had the same issue: https://github.com/balderdashy/waterline/issues/707
This is currently being addressed via https://github.com/balderdashy/waterline/issues/1133#issuecomment-158526482 and balderdashy/waterline-schema#32 .

[particlebanana]

@devinivy I don't think the above addresses this issue. It would need to be tested if it happens to be working. I think this would need to setup to run manually though.

[devinivy]

When collections are initialized, junction/through tables go through a particular "migration" process that nixes their lifecycle callbacks. I figured your changes would allow one to not mark the through table as a waterline-created junction table. It is possible that there's more work that would need to be done. The relevant area to look is here: https://github.com/balderdashy/waterline/blob/f8b499ef549f864a813b1eca5bb591f0ec210ac6/lib/waterline.js#L127-L138 .

[sailsbot]

Thanks for posting, @GeorgeSapkin. I'm a repo bot-- nice to meet you!

It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message. On the other hand, if you are still waiting on a patch, please:

• review our contribution guide to make sure this submission meets our criteria (only verified bugs with documented features, please; no questions, commentary, or bug reports about undocumented features or unofficial plugins)
• create a new issue with the latest information, including updated version details with error messages, failing tests, and a link back to the original issue. This allows GitHub to automatically create a back-reference for future visitors arriving from search engines.

Thanks so much for your help!

[particlebanana]

Updated roadmap with this feature