Skip to content

Commit ef605f2

Browse files
joshualittliamhelmer
authored andcommitted
feat(core): Disable fast ack helper for hints. (google-gemini#21011)
1 parent 488ef84 commit ef605f2

File tree

5 files changed

+0
-36
lines changed

5 files changed

+0
-36
lines changed

packages/cli/src/integration-tests/modelSteering.test.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ describe('Model Steering Integration', () => {
6565
// Resolve list_directory (Proceed)
6666
await rig.resolveTool('ReadFolder');
6767

68-
// Wait for the model to process the hint and output the next action
69-
// Based on steering.responses, it should first acknowledge the hint
70-
await rig.waitForOutput('ACK: I will focus on .txt files now.');
71-
7268
// Then it should proceed with the next action
7369
await rig.waitForOutput(
7470
/Since you want me to focus on .txt files,[\s\S]*I will read file1.txt/,
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
{"method":"generateContentStream","response":[{"candidates":[{"content":{"role":"model","parts":[{"text":"Starting a long task. First, I'll list the files."},{"functionCall":{"name":"list_directory","args":{"dir_path":"."}}}]},"finishReason":"STOP"}]}]}
2-
{"method":"generateContent","response":{"candidates":[{"content":{"role":"model","parts":[{"text":"ACK: I will focus on .txt files now."}]},"finishReason":"STOP"}]}}
32
{"method":"generateContentStream","response":[{"candidates":[{"content":{"role":"model","parts":[{"text":"I see the files. Since you want me to focus on .txt files, I will read file1.txt."},{"functionCall":{"name":"read_file","args":{"file_path":"file1.txt"}}}]},"finishReason":"STOP"}]}]}
43
{"method":"generateContentStream","response":[{"candidates":[{"content":{"role":"model","parts":[{"text":"I have read file1.txt. Task complete."}]},"finishReason":"STOP"}]}]}

packages/cli/src/ui/AppContainer.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ import {
8282
ChangeAuthRequestedError,
8383
ProjectIdRequiredError,
8484
CoreToolCallStatus,
85-
generateSteeringAckMessage,
8685
buildUserSteeringHintPrompt,
8786
logBillingEvent,
8887
ApiKeyUpdatedEvent,
@@ -2109,15 +2108,6 @@ Logging in with Google... Restarting Gemini CLI to continue.
21092108
return;
21102109
}
21112110

2112-
void generateSteeringAckMessage(
2113-
config.getBaseLlmClient(),
2114-
pendingHint,
2115-
).then((ackText) => {
2116-
historyManager.addItem({
2117-
type: 'info',
2118-
text: ackText,
2119-
});
2120-
});
21212111
void submitQuery([{ text: buildUserSteeringHintPrompt(pendingHint) }]);
21222112
}, [
21232113
config,

packages/cli/src/ui/hooks/useGeminiStream.test.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -807,14 +807,6 @@ describe('useGeminiStream', () => {
807807
expect(injectedHintPart.text).toContain(
808808
'Do not cancel/skip tasks unless the user explicitly cancels them.',
809809
);
810-
expect(
811-
mockAddItem.mock.calls.some(
812-
([item]) =>
813-
item?.type === 'info' &&
814-
typeof item.text === 'string' &&
815-
item.text.includes('Got it. Focusing on tests only.'),
816-
),
817-
).toBe(true);
818810

819811
expect(mockRunInDevTraceSpan).toHaveBeenCalledWith(
820812
expect.objectContaining({

packages/cli/src/ui/hooks/useGeminiStream.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import {
3535
CoreEvent,
3636
CoreToolCallStatus,
3737
buildUserSteeringHintPrompt,
38-
generateSteeringAckMessage,
3938
GeminiCliOperation,
4039
getPlanModeExitMessage,
4140
} from '@google/gemini-cli-core';
@@ -1761,18 +1760,6 @@ export const useGeminiStream = (
17611760
responsesToSend.unshift({
17621761
text: buildUserSteeringHintPrompt(hintText),
17631762
});
1764-
void generateSteeringAckMessage(
1765-
config.getBaseLlmClient(),
1766-
hintText,
1767-
).then((ackText) => {
1768-
addItem({
1769-
type: 'info',
1770-
icon: '· ',
1771-
color: theme.text.secondary,
1772-
marginBottom: 1,
1773-
text: ackText,
1774-
} as HistoryItemInfo);
1775-
});
17761763
}
17771764
}
17781765

0 commit comments

Comments
 (0)