Fixed reset of BABEL_ENV when options.forceEnv is used#420
Merged
danez merged 1 commit intobabel:masterfrom Mar 15, 2017
Merged
Fixed reset of BABEL_ENV when options.forceEnv is used#420danez merged 1 commit intobabel:masterfrom
danez merged 1 commit intobabel:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 83.23% 84.18% +0.94%
==========================================
Files 6 6
Lines 173 177 +4
Branches 40 41 +1
==========================================
+ Hits 144 149 +5
Misses 12 12
+ Partials 17 16 -1
Continue to review full report at Codecov.
|
danez
approved these changes
Mar 15, 2017
Member
|
Good catch. thanks for fixing. |
Contributor
Author
|
Took a while to figure out why such "random" behaviour of my app :-) No probs and thanks for merge. |
This was referenced Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
After using 'forceEnv' option, BABEL_ENV is set to "undefined" (string), causing
unintended behaviour of babel running in different env.
What is the new behavior?
BABEL_ENV is correctly reset to previous value OR deleted if it wasn't set before
Does this PR introduce a breaking change?
Other
Some new serial tests added to test the environment variable clearing. Serial is needed
because otherwise, parallel execution interfere with setting/clearing of the variable.
Maybe these tests could be done with less config - feel free to change/update them :)