Fix multiple collection reads and improve caching#79
Merged
Conversation
This way as other tests cases are added the existing tests will expand coverage.
The single-item-stac schema is still broken, so it is the exception.
This is being done directly against the JSON from pystac.serialization.common_properties, and this code was duplicating that effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #55, where collections were being read multiple times per item and causing things to be really slow when reading from remote catalogs.
The caching logic is improved, and all common property merging happens in one place.
Depends on #77
Fixes #55