use fadvise correctly (taco-project#44)

charliecgxu · web-flow · commit 1ea33a21f427 · 2025-07-11T15:21:15.000+08:00
Signed-off-by: charliecgxu &lt;charliecgxu@tencent.com&gt;
diff --git a/csrc/transfer_ssd.cpp b/csrc/transfer_ssd.cpp
@@ -214,7 +214,11 @@ void transfer_kv_blocks_ssd(
         throw std::runtime_error("Thread failed to open file: " +
                                  std::string(strerror(errno)));
       }
-      posix_fadvise(fd, 0, 0, POSIX_FADV_SEQUENTIAL | POSIX_FADV_WILLNEED);
+
+      if (!o_direct_flag) {
+          posix_fadvise(fd, 0, 0, POSIX_FADV_SEQUENTIAL);
+          posix_fadvise(fd, 0, 0, POSIX_FADV_WILLNEED);
+      }
       fds[i].push_back(fd);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,11 @@ void transfer_kv_blocks_ssd(`
`214`	`214`	`throw std::runtime_error("Thread failed to open file: " +`
`215`	`215`	`std::string(strerror(errno)));`
`216`	`216`	`}`
`217`		`- posix_fadvise(fd, 0, 0, POSIX_FADV_SEQUENTIAL \| POSIX_FADV_WILLNEED);`
	`217`	`+`
	`218`	`+ if (!o_direct_flag) {`
	`219`	`+ posix_fadvise(fd, 0, 0, POSIX_FADV_SEQUENTIAL);`
	`220`	`+ posix_fadvise(fd, 0, 0, POSIX_FADV_WILLNEED);`
	`221`	`+ }`
`218`	`222`	`fds[i].push_back(fd);`
`219`	`223`	`}`
`220`	`224`	`}`