Use a custom executor service if config is set #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlinzeng-db
changed the title
vihangk1
approved these changes
Apr 1, 2024
vihangk1
left a comment
vihangk1
left a comment
There was a problem hiding this comment.
I reviewed the changes and they look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick and enhancement of the original PR submitted by Databricks. #11
The original PR explains the intention pretty well:
The first commit of the change is a pure cherry-pick. 2352c78
The second commit is an enhancement horizontally. As we found out there were quite some other thread pools used in the glue client that didn't support configuration executor service.
The third commit is an optimization to ask all those instances to share the configurable executor services just as they did before the executor service became configurable.
I do have tests in this PR but I cannot really compile locally so I do not really test this out in UT tests yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.