From 294d476a05181cd0d2dd7ce9c37076e99127f589 Mon Sep 17 00:00:00 2001 From: Simon Kok Date: Thu, 28 Mar 2024 16:40:59 +0100 Subject: [PATCH] Fix CloudFormation cross-region changeset approval **Why?** With the CloudFormation deployment provider: It would fail to create the pipeline if one were to set the `change_set_approval` property to `True`, while the pipeline lives in another region than where it is asked to deploy to. **What?** * The approval action should be performed in the region that hosts the pipeline. Not the target region. --- .../adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py b/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py index e84318b0a..2aa73a1e7 100644 --- a/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py +++ b/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py @@ -43,7 +43,7 @@ def generate_actions(targets, region, map_params, target_approval_mode): name=f"{target['name']}-{region}", provider="Manual", category="Approval", - region=region, + region=ADF_DEPLOYMENT_REGION, target=target, run_order=2, map_params=map_params,