Codereview comments

Author: StewartW

src/lambda_codebase/account_processing/get_account_regions.py

@@ -16,27 +16,26 @@
 ADF_ROLE_NAME = os.getenv("ADF_ROLE_NAME")
 AWS_PARTITION = os.getenv("AWS_PARTITION")
 
+
 def get_default_regions_for_account(ec2_client):
-    default_regions = [
-    region["RegionName"]
-    for region in ec2_client.describe_regions(
+    filtered_regions = ec2_client.describe_regions(
         AllRegions=False,
         Filters=[
             {
                 "Name": "opt-in-status",
                 "Values": [
                     "opt-in-not-required",
-                    "opted-in"
+                    "opted-in",
                 ],
-            }
+            },
         ],
     )["Regions"]
-    ]
+    default_regions = [region["RegionName"] for region in filtered_regions]
     return default_regions
 
 
 def lambda_handler(event, _):
-    LOGGER.info("Fetching Default regions %s", event.get('account_full_name'))
+    LOGGER.info("Fetching Default regions %s", event.get("account_full_name"))
     sts = STS()
     account_id = event.get("account_id")
     role = sts.assume_cross_account_role(

src/lambda_codebase/account_processing/tests/test_account_tags.py

@@ -12,10 +12,9 @@
 
 global_sdk_config.set_sdk_enabled(False)
 
-# pylint: disable=W0106
+# pylint: disable=W0106,R0201
 class SuccessTestCase(unittest.TestCase):
-    @staticmethod
-    def test_account_tag_creation():
+    def test_account_tag_creation(self):
         test_event = {"account_id": "123456789012", "tags": [{"CreatedBy": "ADF"}]}
         ou_client = boto3.client("organizations")
         stubber = Stubber(ou_client)
@@ -31,3 +30,33 @@ def test_account_tag_creation():
         create_account_tags(
             test_event.get("account_id"), test_event.get("tags"), ou_client
         )
+        stubber.assert_no_pending_responses()
+
+    def test_account_tag_creation_multiple_tags(self):
+        test_event = {
+            "account_id": "123456789012",
+            "tags": [
+                {
+                    "CreatedBy": "ADF",
+                    "TagName": "TagValue",
+                }
+            ],
+        }
+        ou_client = boto3.client("organizations")
+        stubber = Stubber(ou_client)
+        stubber.add_response(
+            "tag_resource",
+            {},
+            {
+                "Tags": [
+                    {"Key": "CreatedBy", "Value": "ADF"},
+                    {"Key": "TagName", "Value": "TagValue"},
+                ],
+                "ResourceId": "123456789012",
+            },
+        ),
+        stubber.activate()
+        create_account_tags(
+            test_event.get("account_id"), test_event.get("tags"), ou_client
+        )
+        stubber.assert_no_pending_responses()