Reject more characters from a CloudFormation Stack name (#346)

benbridts · web-flow · commit b5b333ddea57 · 2021-04-09T10:16:22.000+02:00
Signed-off-by: Simon &lt;sbkok@users.noreply.github.com&gt;
diff --git a/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py b/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py
@@ -21,7 +21,8 @@
         max_attempts=10
     )
 )
-CFN_UNACCEPTED_CHARS = re.compile(r"[^-a-zA-Z0-9:/._+]")
+# A stack name can contain only alphanumeric characters (case sensitive) and hyphens.
+CFN_UNACCEPTED_CHARS = re.compile(r"[^-a-zA-Z0-9]")
 
 class StackProperties:
     clean_stack_status = [

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@`
`21`	`21`	`max_attempts=10`
`22`	`22`	`)`
`23`	`23`	`)`
`24`		`-CFN_UNACCEPTED_CHARS = re.compile(r"[^-a-zA-Z0-9:/._+]")`
	`24`	`+# A stack name can contain only alphanumeric characters (case sensitive) and hyphens.`
	`25`	`+CFN_UNACCEPTED_CHARS = re.compile(r"[^-a-zA-Z0-9]")`
`25`	`26`
`26`	`27`	`class StackProperties:`
`27`	`28`	`clean_stack_status = [`