Addressing code review comments

Author: Stewart Wallace

src/lambda_codebase/account_processing/process_account_files.py

@@ -12,6 +12,7 @@
 import tempfile
 import logging
 from typing import Any, TypedDict
+import re
 import yaml
 
 from yaml.error import YAMLError
@@ -141,36 +142,7 @@ def process_account_list(all_accounts, accounts_in_file):
 
 
 def sanitize_account_name_for_snf(account_name):
-    unsupported_characters = [
-        "<",
-        ">",
-        "{",
-        "}",
-        "[",
-        "]",
-        " ",
-        "?",
-        "*",
-        '"',
-        "#",
-        "%",
-        "\\",
-        "^",
-        "|",
-        "~",
-        "`",
-        "$",
-        "&",
-        ",",
-        ";",
-        ":",
-        "/",
-    ]
-    sanitized_name = account_name[:30]
-    for char in unsupported_characters:
-        sanitized_name = sanitized_name.replace(char, "")
-
-    return sanitized_name
+    return re.sub("[^a-zA-Z0-9_]", "_", account_name[:30])
 
 
 def start_executions(

src/lambda_codebase/account_processing/tests/test_account_file_processing.py

@@ -78,19 +78,19 @@ def test_get_sanitize_account_name(self):
             sanitize_account_name_for_snf(
                 "thisIsALongerAccountName ForTestingTruncatedNames"
             ),
-            "thisIsALongerAccountNameForTe",
+            "thisIsALongerAccountName_ForTe",
         )
         self.assertEqual(
             sanitize_account_name_for_snf("this accountname <has illegal> chars"),
-            "thisaccountnamehasillegal",
+            "this_accountname__has_illegal_",
         )
         self.assertEqual(
-            sanitize_account_name_for_snf("this accountname \\has illegal chars"),
-            "thisaccountnamehasillegal",
+            sanitize_account_name_for_snf("this accountname \\has illegal"),
+            "this_accountname__has_illegal",
         )
         self.assertEqual(
             sanitize_account_name_for_snf("^startswithanillegalchar"),
-            "startswithanillegalchar",
+            "_startswithanillegalchar",
         )
         self.assertEqual(
             len(