Skip to content

Commit 4771a32

Browse files
committed
Ensure tox fails at first pytest failure
**Why?** At the moment, pytest failures were ignored due to a change in the Makefile used to execute tests. The ADF CI GitHub Workflow would result in a success, even when a test case failed. **What?** Fixed by exiting on the first failure using Makefile foreach instead.
1 parent 87c0dfa commit 4771a32

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

Makefile.tox

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@ all: test lint
1111

1212
test:
1313
# Run unit tests
14-
( \
15-
for config in $(TEST_CONFIGS); do \
16-
pytest $$(dirname $$config) -vvv -s -c $$config; \
17-
done \
14+
@ $(foreach config,$(TEST_CONFIGS), \
15+
pytest $$(dirname $(config)) -vvv -s -c $(config) || exit 1; \
1816
)
1917

2018
lint:

0 commit comments

Comments
 (0)