chore: Fix new clippy warnings (#2590)

Author: goatgoose

dc/s2n-quic-dc/src/packet/tag.rs

@@ -79,7 +79,7 @@ decoder_value!(
                     Ok((Self::UnknownPathSecret(tag), buffer))
                 }
                 // reserve this range for other packet types
-                0b0110_0000..=0b0111_1111 => Err(s2n_codec::DecoderError::InvariantViolation(
+                0b0110_0011..=0b0111_1111 => Err(s2n_codec::DecoderError::InvariantViolation(
                     "unexpected packet tag",
                 )),
                 0b1000_0000..=0b1111_1111 => Err(s2n_codec::DecoderError::InvariantViolation(

dc/s2n-quic-dc/src/stream/recv/error.rs

@@ -214,7 +214,7 @@ impl From<Kind> for std::io::ErrorKind {
             Kind::TruncatedTransport => ErrorKind::UnexpectedEof,
             Kind::OutOfRange => ErrorKind::ConnectionAborted,
             Kind::OutOfOrder { .. } => ErrorKind::InvalidData,
-            Kind::UnexpectedRetransmission { .. } => ErrorKind::InvalidData,
+            Kind::UnexpectedRetransmission => ErrorKind::InvalidData,
             Kind::IdleTimeout => ErrorKind::TimedOut,
             Kind::KeyReplayPrevented => ErrorKind::PermissionDenied,
             Kind::KeyReplayMaybePrevented { .. } => ErrorKind::PermissionDenied,

quic/s2n-quic-core/src/inet/ethernet.rs

@@ -191,9 +191,7 @@ mod tests {
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_test", header);
 
-        for byte in &mut buffer {
-            *byte = 255;
-        }
+        buffer.fill(255);
         let decoder = DecoderBuffer::new(&buffer);
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_filled_test", header);

quic/s2n-quic-core/src/inet/ipv4.rs

@@ -815,9 +815,7 @@ mod tests {
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_test", header);
 
-        for byte in &mut buffer {
-            *byte = 255;
-        }
+        buffer.fill(255);
         let decoder = DecoderBuffer::new(&buffer);
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_filled_test", header);

quic/s2n-quic-core/src/inet/ipv6.rs

@@ -724,9 +724,7 @@ mod tests {
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_test", header);
 
-        for byte in &mut buffer {
-            *byte = 255;
-        }
+        buffer.fill(255);
         let decoder = DecoderBuffer::new(&buffer);
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_filled_test", header);

quic/s2n-quic-core/src/inet/udp.rs

@@ -105,9 +105,7 @@ mod tests {
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_test", header);
 
-        for byte in &mut buffer {
-            *byte = 255;
-        }
+        buffer.fill(255);
         let decoder = DecoderBuffer::new(&buffer);
         let (header, _) = decoder.decode::<&Header>().unwrap();
         insta::assert_debug_snapshot!("snapshot_filled_test", header);

quic/s2n-quic-core/src/packet/number/packet_number_range.rs

@@ -160,10 +160,10 @@ mod test {
         let start = PacketNumberSpace::Handshake.new_packet_number(VarInt::from_u8(1));
         let end = PacketNumberSpace::Handshake.new_packet_number(VarInt::from_u8(1));
 
-        let range = PacketNumberRange::new(start, end);
+        let mut range = PacketNumberRange::new(start, end);
 
         assert_eq!(1, range.count());
-        assert_eq!(start, range.last().unwrap());
+        assert_eq!(start, range.next_back().unwrap());
     }
 
     #[test]

quic/s2n-quic-core/src/path/ecn.rs

@@ -207,7 +207,7 @@ impl Controller {
     ///
     /// * `newly_acked_ecn_counts` - total ECN counts that were sent on packets newly acknowledged by the peer
     /// * `sent_packet_ecn_counts` - total ECN counts for all outstanding packets, including those newly
-    ///                              acknowledged during this validation
+    ///   acknowledged during this validation
     /// * `baseline_ecn_counts` - the ECN counts present in the Ack frame the last time ECN counts were processed
     /// * `ack_frame_ecn_counts` - the ECN counts present in the current Ack frame (if any)
     /// * `now` - the time the Ack frame was received