-
Notifications
You must be signed in to change notification settings - Fork 436
chore: add protocol to url in 'ecs-preview app show' #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iamhopaul123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM! Just few questions.
SoManyHs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!! 🎉 Could you also add output from manually testing the app show command plz? :)
|
Could you also update init_test.go, line 96 in the e2e tests? From TrimSuffix to |
efekarakus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
kohidave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also take a look at this block? https://github.com/aws/amazon-ecs-cli-v2/pull/733/files#diff-3c6b0eccdf2aa38416345540f2b37b22R98
You'll have trim the 'http://' as well
which block? wasn't sure if you meant to include some line numbers in that link -- for me it takes me to line 100 of |
Yup. After: |
kohidave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fresh ✨
Prepended the protocol to the url string for a more user-friendly output for 'app show'.
Included changes in go.mod and go.sum because of advice given here: https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.