feat(cli): port mapping flags and prompts #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvtujo
force-pushed
the
init-port-mapping
branch
from
dc31158 to
c53a623
Compare
bvtujo
force-pushed
the
init-port-mapping
branch
from
5c6644f to
229d198
Compare
bvtujo
changed the title
kohidave
reviewed
Mar 6, 2020
Contributor
kohidave
left a comment
kohidave
left a comment
There was a problem hiding this comment.
This looks slick!
One request - could you update the end to end test, as well? To specify the --port field for init and app init. e2e/internal/cli.go i think.
iamhopaul123
reviewed
Mar 6, 2020
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Overall LGTM! Just nits.
kohidave
reviewed
Mar 6, 2020
kohidave
approved these changes
Mar 6, 2020
Contributor
kohidave
left a comment
kohidave
left a comment
There was a problem hiding this comment.
Looks delightful ! @iamhopaul123 has some good comments though!
One final nit on the description of the flag.
Move default port string to const Rephrase app port prompt Rephrase error messages in app init
Refactor error messages, prompts, and consts in app init tests
iamhopaul123
approved these changes
Mar 6, 2020
efekarakus
reviewed
Mar 6, 2020
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks good! Sorry for the delay, just a question
Comment on lines
+147
to
+149
| type port interface { | ||
| Set(number int) error | ||
| } |
Contributor
There was a problem hiding this comment.
Is this interface used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a port mapping flag to app init and prompts/validation when flag is not provided.
Addresses #595, #703.
I'm punting until next week on adding automagic dockerfile guesses in favor of getting core flag and prompt functionality merged in as quickly as possible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
ecs-preview initbehaviorecs-preview app initbehavior