Skip to content

chore(e2e): migrate AWS SDK for JavaScript v2 APIs to v3 #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore(e2e): migrate AWS SDK for JavaScript v2 APIs to v3 #5822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/addons/hello/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"start": "node server.js"
},
"dependencies": {
"aws-sdk": ">= 2.249.1",
"@aws-sdk/client-s3": ">= 3.0.0",
"express": "^4.16.1",
"pg": "^8.5.1"
}
Expand Down
4 changes: 2 additions & 2 deletions e2e/addons/hello/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

const express = require('express');
const AWS = require('aws-sdk');
const { S3 } = require('@aws-sdk/client-s3');

// Constants
const PORT = 80;
Expand All @@ -22,7 +22,7 @@ const pool = new Pool({
})

// Get bucket name from environment variable.
const s3 = new AWS.S3({apiVersion: '2006-03-01'});
const s3 = new S3();
const bucketName = process.env.MYBUCKET_NAME

// App
Expand Down