feat(manifest): add env var interpolation #2917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
force-pushed
the
apply-manifest-interpolate
branch
from
36e828b to
dc17617
Compare
efekarakus
changed the title
efekarakus
reviewed
Oct 14, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great ! super tiny comments
internal/pkg/deploy/cloudformation/stack/testdata/workloads/svc-staging.params.json
Show resolved
Hide resolved
efekarakus
approved these changes
Oct 14, 2021
Lou1415926
reviewed
Oct 18, 2021
| cmd: exec.NewCmd(), | ||
| sessProvider: sessions.NewProvider(), | ||
| snsTopicGetter: deployStore, | ||
| newInterpolator: newManifestInterpolator, |
Contributor
There was a problem hiding this comment.
What do you think of just doing
Suggested change
| newInterpolator: newManifestInterpolator, | |
| newInterpolator: manifest.NewInterpolator, |
and same in job_deploy.go
Contributor
Author
There was a problem hiding this comment.
they return to different type :)
internal/pkg/deploy/cloudformation/stack/lb_web_service_integration_test.go
Show resolved
Hide resolved
iamhopaul123
force-pushed
the
apply-manifest-interpolate
branch
from
624c951 to
acf95f7
Compare
Lou1415926
approved these changes
Oct 19, 2021
Lou1415926
pushed a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Oct 25, 2021
<!-- Provide summary of changes --> Part of aws#2912. Doc will be added in the next PR. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2912. Doc will be added in the next PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.