CodeBuild Setup for GitHub Docker Image Builds #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
==========================================
+ Coverage 78.89% 78.92% +0.02%
==========================================
Files 677 677
Lines 115526 115525 -1
Branches 16249 16249
==========================================
+ Hits 91150 91180 +30
+ Misses 23579 23551 -28
+ Partials 797 794 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
force-pushed
the
gh-docker-image-build-p1
branch
from
4a41100 to
d25b5ea
Compare
skmcgrail
force-pushed
the
gh-docker-image-build-p1
branch
from
d25b5ea to
ec544dd
Compare
justsmth
approved these changes
Oct 14, 2025
| staging_repo = ecr.Repository(self, "aws-lc-ecr-staging", | ||
| image_tag_mutability=ecr.TagMutability.IMMUTABLE, | ||
| lifecycle_rules=[ecr.LifecycleRule( | ||
| max_image_age=Duration.days(7), |
Contributor
There was a problem hiding this comment.
NP: In what situations would an image hit the 7-day maximum? Do we need 7 days?
Member
Author
There was a problem hiding this comment.
It can probably be shortened if we want. It's mainly for historical uses or to be able to look at an image that was staged if we forsee doing more extensive image testing in the future and want to deep dive into one of the docker images that failed to get to the publishing step.
torben-hansen
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is about one of three (or four) PRs that I need to parcel out to roll out this change. This first introduces the necessary CodeBuild project bits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.