TLS Transfer Serialization Improvements #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
skmcgrail
commented
Aug 15, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 78.75% 78.73% -0.02%
==========================================
Files 663 663
Lines 113346 113622 +276
Branches 15946 15974 +28
==========================================
+ Hits 89264 89464 +200
- Misses 23304 23381 +77
+ Partials 778 777 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
force-pushed
the
tls-transfer
branch
2 times, most recently
from
85b387d to
530f170
Compare
skmcgrail
force-pushed
the
tls-transfer
branch
2 times, most recently
from
17967b3 to
68f4ff2
Compare
justsmth
reviewed
Sep 3, 2025
skmcgrail
force-pushed
the
tls-transfer
branch
from
68f4ff2 to
3fbe701
Compare
skmcgrail
force-pushed
the
tls-transfer
branch
from
3fbe701 to
591bcb4
Compare
skmcgrail
force-pushed
the
tls-transfer
branch
from
591bcb4 to
28b0b1a
Compare
samuel40791765
approved these changes
Sep 4, 2025
justsmth
approved these changes
Sep 4, 2025
Comment on lines
+233
to
+235
| if (data_start_ > end_ptr || data_start_ < start_ptr || | ||
| data_end_ptr > end_ptr || data_end_ptr < start_ptr || size_ > cap_ || | ||
| remaining_ptr > end_ptr || remaining_ptr < start_ptr) { |
Contributor
There was a problem hiding this comment.
Can any of these potentially be equal?
Comment on lines
+171
to
+177
| #define GUARD_SUSPENDED_STATE(ptr,code) \ | ||
| do { \ | ||
| if (ptr->is_suspended_state) { \ | ||
| OPENSSL_PUT_ERROR(SSL, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED); \ | ||
| return code; \ | ||
| } \ | ||
| } while (0) |
Contributor
There was a problem hiding this comment.
NP: Use parentheses: (ptr)->is_suspended_state.
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Sep 9, 2025
Addresses CryptoAlg-3221, CryptoAlg-3220, CryptoAlg-3219, CryptoAlg-3218, CryptoAlg-3217, CryptoAlg-3216, CryptoAlg-3215, CryptoAlg-3214, CryptoAlg-3212, CryptoAlg-3211 This pull request addresses and improves the experimental TLS transfer serialization feature. Primarily focusing on performance of restored connections for the SSLBuffer by improving the serialization format, and hardens the checking of the data structures on deserialization. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 26da017)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-3221, CryptoAlg-3220, CryptoAlg-3219, CryptoAlg-3218, CryptoAlg-3217, CryptoAlg-3216, CryptoAlg-3215, CryptoAlg-3214, CryptoAlg-3212, CryptoAlg-3211
Description of changes:
This pull request addresses and improves the experimental TLS transfer serialization feature. Primarily focusing on performance of restored connections for the SSLBuffer by improving the serialization format, and hardens the checking of the data structures on deserialization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.