Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 29, 2025

Reason for this change

The repository was using npx cdk-generate-synthetic-examples@latest which could lead to unexpected builds due to the latest version being used. This change locks the version to ensure reproducible builds. It also allows us to release changes to cdk-generate-synthetic-examples without having to worry much about the implications on this repo.

Description of changes

  • Updated cdk-generate-synthetic-examples from ^0.2.32 to ^0.2.36 in package.json
  • Added npm scripts rosetta and synthetic-examples to use locked versions via yarn
  • Updated scripts/run-rosetta.sh to use yarn run instead of npx for both tools
  • Removed init template upgrades from yarn-upgrade workflow (unrelated cleanup)
  • Minor formatting fixes in yarn-upgrade workflow

This ensures all developers and CI use the same version of the synthetic examples generator, preventing potential inconsistencies.

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

  • Verified the scripts use the locked versions from package.json
  • Confirmed yarn.lock contains the updated dependencies

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 29, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2025 13:36
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 1 hour 30 minutes 29 seconds in the queue, including 45 minutes 25 seconds waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3e048c1 into main Dec 1, 2025
16 of 17 checks passed
@mergify mergify bot deleted the mrgrain/chore/synthetic-exmaples branch December 1, 2025 10:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants