Skip to content

Conversation

@suzukyz
Copy link
Contributor

@suzukyz suzukyz commented May 10, 2023

When devParameter is not set, it is difficult to understand the behavior of whether the CDK defaults are used or not, so env was modified.
Also, removed the default region because it's not be needed.


By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).

Copy link
Contributor

@konokenj konokenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b301434 into aws-samples:main May 16, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants