Add validation functions accepting string length (ros2#135)

Add rmw_validate_full_topic_name_with_size()
Add rmw_validate_namespace_with_size()
Add rmw_validate_node_name_with_size()

Signed-off-by: Devin Bonnie <[email protected]>

Author: sloretz

rmw/include/rmw/validate_full_topic_name.h

@@ -89,6 +89,22 @@ rmw_validate_full_topic_name(
   int * validation_result,
   size_t * invalid_index);
 
+/// Deterimine if a given topic name is valid.
+/**
+ * This is an overload with an extra parameter for the length of topic_name.
+ * \param[in] topic_name_length The number of characters in topic_name.
+ *
+ * \sa rmw_validate_full_topic_name(const char *, int *, size_t *)
+ */
+RMW_PUBLIC
+RMW_WARN_UNUSED
+rmw_ret_t
+rmw_validate_full_topic_name_with_size(
+  const char * topic_name,
+  size_t topic_name_length,
+  int * validation_result,
+  size_t * invalid_index);
+
 /// Return a validation result description, or NULL if unknown or RMW_TOPIC_VALID.
 RMW_PUBLIC
 RMW_WARN_UNUSED

rmw/include/rmw/validate_namespace.h

@@ -95,6 +95,22 @@ rmw_validate_namespace(
   int * validation_result,
   size_t * invalid_index);
 
+/// Deterimine if a given namespace is valid.
+/**
+ * This is an overload with an extra parameter for the length of namespace_.
+ * \param[in] namespace_length The number of characters in namespace_.
+ *
+ * \sa rmw_validate_namespace(const char *, int *, size_t *)
+ */
+RMW_PUBLIC
+RMW_WARN_UNUSED
+rmw_ret_t
+rmw_validate_namespace_with_size(
+  const char * namespace_,
+  size_t namespace_length,
+  int * validation_result,
+  size_t * invalid_index);
+
 /// Return a validation result description, or NULL if unknown or RMW_NAMESPACE_VALID.
 RMW_PUBLIC
 RMW_WARN_UNUSED

rmw/include/rmw/validate_node_name.h

@@ -83,6 +83,22 @@ rmw_validate_node_name(
   int * validation_result,
   size_t * invalid_index);
 
+/// Deterimine if a given node name is valid.
+/**
+ * This is an overload with an extra parameter for the length of node_name.
+ * \param[in] node_name_length The number of characters in node_name.
+ *
+ * \sa rmw_validate_node_name(const char *, int *, size_t *)
+ */
+RMW_PUBLIC
+RMW_WARN_UNUSED
+rmw_ret_t
+rmw_validate_node_name_with_size(
+  const char * node_name,
+  size_t node_name_length,
+  int * validation_result,
+  size_t * invalid_index);
+
 /// Return a validation result description, or NULL if unknown or RMW_NODE_NAME_VALID.
 RMW_PUBLIC
 RMW_WARN_UNUSED

rmw/src/validate_full_topic_name.c

@@ -24,14 +24,27 @@ rmw_validate_full_topic_name(
   const char * topic_name,
   int * validation_result,
   size_t * invalid_index)
+{
+  if (!topic_name) {
+    return RMW_RET_INVALID_ARGUMENT;
+  }
+  return rmw_validate_full_topic_name_with_size(
+    topic_name, strlen(topic_name), validation_result, invalid_index);
+}
+
+rmw_ret_t
+rmw_validate_full_topic_name_with_size(
+  const char * topic_name,
+  size_t topic_name_length,
+  int * validation_result,
+  size_t * invalid_index)
 {
   if (!topic_name) {
     return RMW_RET_INVALID_ARGUMENT;
   }
   if (!validation_result) {
     return RMW_RET_INVALID_ARGUMENT;
   }
-  size_t topic_name_length = strlen(topic_name);
   if (topic_name_length == 0) {
     *validation_result = RMW_TOPIC_INVALID_IS_EMPTY_STRING;
     if (invalid_index) {

rmw/src/validate_namespace.c

@@ -28,6 +28,20 @@ rmw_validate_namespace(
   const char * namespace_,
   int * validation_result,
   size_t * invalid_index)
+{
+  if (!namespace_) {
+    return RMW_RET_INVALID_ARGUMENT;
+  }
+  return rmw_validate_namespace_with_size(
+    namespace_, strlen(namespace_), validation_result, invalid_index);
+}
+
+rmw_ret_t
+rmw_validate_namespace_with_size(
+  const char * namespace_,
+  size_t namespace_length,
+  int * validation_result,
+  size_t * invalid_index)
 {
   if (!namespace_) {
     return RMW_RET_INVALID_ARGUMENT;
@@ -36,7 +50,6 @@ rmw_validate_namespace(
     return RMW_RET_INVALID_ARGUMENT;
   }
 
-  size_t namespace_length = strlen(namespace_);
   // Special case for root namepsace
   if (namespace_length == 1 && namespace_[0] == '/') {
     // Ok to return here, it is valid and will not exceed RMW_NAMESPACE_MAX_LENGTH.

rmw/src/validate_node_name.c

@@ -24,14 +24,27 @@ rmw_validate_node_name(
   const char * node_name,
   int * validation_result,
   size_t * invalid_index)
+{
+  if (!node_name) {
+    return RMW_RET_INVALID_ARGUMENT;
+  }
+  return rmw_validate_node_name_with_size(
+    node_name, strlen(node_name), validation_result, invalid_index);
+}
+
+rmw_ret_t
+rmw_validate_node_name_with_size(
+  const char * node_name,
+  size_t node_name_length,
+  int * validation_result,
+  size_t * invalid_index)
 {
   if (!node_name) {
     return RMW_RET_INVALID_ARGUMENT;
   }
   if (!validation_result) {
     return RMW_RET_INVALID_ARGUMENT;
   }
-  size_t node_name_length = strlen(node_name);
   if (node_name_length == 0) {
     *validation_result = RMW_NODE_NAME_INVALID_IS_EMPTY_STRING;
     if (invalid_index) {