Skip to content

Conversation

@liustve
Copy link
Contributor

@liustve liustve commented Oct 21, 2025

Description of changes:
Unit tests would occasionally fail because of a transitive timing issue using Python's time() library, see:
https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/18681954286/job/53290674826

  • Add timeout check before each export attempt to fail fast when deadline is exceeded and fixes flaky failing retry test by mocking time to prevent unexpected timeout errors in the test.

  • Updates tox.ini to point the upstream repos to the one currently in pyproject.toml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@liustve liustve requested a review from a team as a code owner October 21, 2025 10:14
@liustve liustve added the skip changelog doesn't need a CHANGELOG entry label Oct 21, 2025
@liustve liustve changed the title Fix flaky randomness in OTLPAwsLogsExporter test Fix flaky jitter tests and add explicit timeout deadline check in OTLPAwsLogsExporter Oct 21, 2025
@liustve liustve removed the skip changelog doesn't need a CHANGELOG entry label Oct 21, 2025
@liustve liustve force-pushed the fix-flaky-test branch 3 times, most recently from 2da167d to 6232099 Compare October 21, 2025 17:52
wangzlei
wangzlei previously approved these changes Oct 21, 2025
@liustve liustve merged commit bf434f4 into main Oct 21, 2025
16 checks passed
@liustve liustve deleted the fix-flaky-test branch October 21, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants