Skip to content

Commit a306fd4

Browse files
committed
Merge branch 'main' into fix_gevent_regression
2 parents fc2b6ec + 6ae6225 commit a306fd4

File tree

5 files changed

+10
-15
lines changed

5 files changed

+10
-15
lines changed

.github/actions/set_up/action.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ runs:
2727

2828
- name: Install tox
2929
shell: bash
30-
run: |
31-
pip install tox==4.30.3
30+
run: pip install tox==3.27.1 tox-factor
3231

3332
- name: Cache tox environment
3433
# Preserves .tox directory between runs for faster installs
@@ -42,7 +41,4 @@ runs:
4241
- name: Run unit tests/benchmarks with tox
4342
if: ${{ inputs.run_unit_tests == 'true' }}
4443
shell: bash
45-
run: |
46-
ENV_NAME="${{ inputs.python_version }}-test-${{ inputs.package_name }}"
47-
echo "Running tox env: $ENV_NAME"
48-
tox -e "$ENV_NAME" -- -ra
44+
run: tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra

CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,3 @@ If your change does not need a CHANGELOG entry, add the "skip changelog" label t
1717
([#497](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/497))
1818
- Fix timeout handling for exceeded deadline in retry logic in OTLPAwsLogsExporter
1919
([#501](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/501))
20-
- Fix: Unable to run ADOT Python unit tests with latest Tox release
21-
([#521](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/521))

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_distro.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# SPDX-License-Identifier: Apache-2.0
33

44
# flake8: noqa: E402
5+
# pylint: disable=wrong-import-position
56

67
# Apply the Gevent's patching as the very first step in the distro.
78
# IMPORTANT: Do not put any imports before the following 2 lines.

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_gevent_patches.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ def _is_gevent_installed() -> bool:
2525
req = Requirement("gevent")
2626
try:
2727
dist_version = version(req.name)
28-
_logger.debug(f"Gevent is installed: {dist_version}")
28+
_logger.debug("Gevent is installed: %s", dist_version)
2929
except PackageNotFoundError as exc:
30-
_logger.debug(f"Gevent is not installed. {exc}")
30+
_logger.debug("Gevent is not installed. %s", exc)
3131
return False
3232
return True
3333

tox.ini

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ commands_pre =
3434
; Install common packages for all the tests. These are not needed in all the
3535
; cases but it saves a lot of boilerplate in this file.
3636
test: pip install botocore
37-
test: pip install opentelemetry-api[test]@{env:CORE_REPO}\#egg=opentelemetry-api&subdirectory=opentelemetry-api
38-
test: pip install opentelemetry-sdk[test]@{env:CORE_REPO}\#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk
39-
test: pip install opentelemetry-instrumentation[test]@{env:CONTRIB_REPO}\#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation
40-
test: pip install opentelemetry-exporter-otlp[test]@{env:CORE_REPO}\#egg=opentelemetry-exporter-otlp&subdirectory=exporter/opentelemetry-exporter-otlp
41-
test: pip install opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils
37+
test: pip install "opentelemetry-api[test] @ {env:CORE_REPO}#egg=opentelemetry-api&subdirectory=opentelemetry-api"
38+
test: pip install "opentelemetry-sdk[test] @ {env:CORE_REPO}#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk"
39+
test: pip install "opentelemetry-instrumentation[test] @ {env:CONTRIB_REPO}#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation"
40+
test: pip install "opentelemetry-exporter-otlp[test] @ {env:CORE_REPO}#egg=opentelemetry-exporter-otlp&subdirectory=exporter/opentelemetry-exporter-otlp"
41+
test: pip install "opentelemetry-test-utils @ {env:CORE_REPO}#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils"
4242
aws-opentelemetry-distro: pip install {toxinidir}/aws-opentelemetry-distro
4343

4444
commands =

0 commit comments

Comments
 (0)