Fully populate test context (#3943)

Author: StephenButtolph

snow/consensus/snowman/consensus_test.go

@@ -521,6 +521,10 @@ func RecordPollSplitVoteNoChangeTest(t *testing.T, factory Factory) {
 
 	firstBlock := snowmantest.BuildChild(snowmantest.Genesis)
 	secondBlock := snowmantest.BuildChild(snowmantest.Genesis)
+	// Ensure that the blocks have at least one bit as a common prefix
+	for firstBlock.IDV.Bit(0) != secondBlock.IDV.Bit(0) {
+		secondBlock = snowmantest.BuildChild(snowmantest.Genesis)
+	}
 
 	require.NoError(sm.Add(firstBlock))
 	require.NoError(sm.Add(secondBlock))

snow/snowtest/context.go

@@ -12,19 +12,22 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/ava-labs/avalanchego/api/metrics"
+	"github.com/ava-labs/avalanchego/chains/atomic"
+	"github.com/ava-labs/avalanchego/database/memdb"
 	"github.com/ava-labs/avalanchego/ids"
 	"github.com/ava-labs/avalanchego/snow"
 	"github.com/ava-labs/avalanchego/snow/validators/validatorstest"
 	"github.com/ava-labs/avalanchego/upgrade/upgradetest"
 	"github.com/ava-labs/avalanchego/utils/constants"
 	"github.com/ava-labs/avalanchego/utils/crypto/bls/signer/localsigner"
 	"github.com/ava-labs/avalanchego/utils/logging"
+	"github.com/ava-labs/avalanchego/vms/platformvm/warp"
 )
 
 var (
+	PChainID    = constants.PlatformChainID
 	XChainID    = ids.GenerateTestID()
 	CChainID    = ids.GenerateTestID()
-	PChainID    = constants.PlatformChainID
 	AVAXAssetID = ids.GenerateTestID()
 
 	errMissing = errors.New("missing")
@@ -56,9 +59,12 @@ func Context(tb testing.TB, chainID ids.ID) *snow.Context {
 	require.NoError(err)
 	publicKey := secretKey.PublicKey()
 
+	memory := atomic.NewMemory(memdb.New())
+	sharedMemory := memory.NewSharedMemory(chainID)
+
 	aliaser := ids.NewAliaser()
-	require.NoError(aliaser.Alias(constants.PlatformChainID, "P"))
-	require.NoError(aliaser.Alias(constants.PlatformChainID, constants.PlatformChainID.String()))
+	require.NoError(aliaser.Alias(PChainID, "P"))
+	require.NoError(aliaser.Alias(PChainID, PChainID.String()))
 	require.NoError(aliaser.Alias(XChainID, "X"))
 	require.NoError(aliaser.Alias(XChainID, XChainID.String()))
 	require.NoError(aliaser.Alias(CChainID, "C"))
@@ -69,33 +75,33 @@ func Context(tb testing.TB, chainID ids.ID) *snow.Context {
 			return 0, nil
 		},
 		GetSubnetIDF: func(_ context.Context, chainID ids.ID) (ids.ID, error) {
-			subnetID, ok := map[ids.ID]ids.ID{
-				constants.PlatformChainID: constants.PrimaryNetworkID,
-				XChainID:                  constants.PrimaryNetworkID,
-				CChainID:                  constants.PrimaryNetworkID,
-			}[chainID]
-			if !ok {
+			switch chainID {
+			case PChainID, XChainID, CChainID:
+				return constants.PrimaryNetworkID, nil
+			default:
 				return ids.Empty, errMissing
 			}
-			return subnetID, nil
 		},
 	}
 
 	return &snow.Context{
 		NetworkID:       constants.UnitTestID,
 		SubnetID:        constants.PrimaryNetworkID,
 		ChainID:         chainID,
-		NodeID:          ids.EmptyNodeID,
+		NodeID:          ids.GenerateTestNodeID(),
 		PublicKey:       publicKey,
 		NetworkUpgrades: upgradetest.GetConfig(upgradetest.Latest),
 
 		XChainID:    XChainID,
 		CChainID:    CChainID,
 		AVAXAssetID: AVAXAssetID,
 
-		Log:      logging.NoLog{},
-		BCLookup: aliaser,
-		Metrics:  metrics.NewPrefixGatherer(),
+		Log:          logging.NoLog{},
+		SharedMemory: sharedMemory,
+		BCLookup:     aliaser,
+		Metrics:      metrics.NewPrefixGatherer(),
+
+		WarpSigner: warp.NewSigner(secretKey, constants.UnitTestID, chainID),
 
 		ValidatorState: validatorState,
 		ChainDataDir:   tb.TempDir(),