@@ -209,7 +209,7 @@ def get_bzojb(bzopts):
209209 import bugzilla # Keep confined to this function
210210 except ImportError:
211211 logging.warning("Bugzilla status exclusion filter configured "
212- "but bugzilla python module unavailable")
212+ "but bugzilla python module unavailable. ")
213213 return None
214214 quiet_bz() # the bugzilla module is very noisy
215215 bz = bugzilla.Bugzilla(url=url)
@@ -246,7 +246,7 @@ def bugged_subthings(control_ini, subthings):
246246 bzopts = dict(control_ini.items('Bugzilla'))
247247 bz = get_bzojb(bzopts)
248248 if bz is None:
249- return set()
249+ return {}
250250 namestobzs = {} # docker_cli/test/name = 12345,67890,...
251251 for name, bzcsv in control_ini.items('NamesToBZs'):
252252 namestobzs[name] = [int(bugnum.strip()) # needed by bz.getbugs()
@@ -314,6 +314,7 @@ def filter_bugged(subthings, bug_blocked, subtest_modules):
314314 "blocked by bugzilla(s): %s", subtest,
315315 bug_blocked[subtest])
316316 subthings.remove(subtest)
317+ return None # mods were done in-place!!!
317318
318319def only_subtests(subthings, subtest_modules):
319320 """
@@ -340,6 +341,7 @@ def write_control_ini(control_ini, resultdir,
340341 exclude_csv = ",".join(subthing_exclude) # + bug_blocked
341342 control_ini.set("Control", "exclude", exclude_csv)
342343 control_ini.write(open(reference_control_ini, "wb"))
344+ return reference_control_ini # in case it's ever needed
343345
344346def filter_subthings(control_path, args):
345347 """
@@ -399,6 +401,7 @@ def step_init():
399401 tag = "test_%s-of-%s" % (index + 1, total)
400402 job.next_step(run_test, control_path, uri, tag, TIMEOUT)
401403 job.next_step(run_envchecks, control_path, uri)
404+ return None # End of test
402405
403406def get_doc_version(control_path):
404407 """
0 commit comments