Lint fixes part 12 #2668
Merged
Lint fixes part 12 #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/cli
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
- Coverage 79.43% 79.41% -0.01%
==========================================
Files 455 455
Lines 47156 47159 +3
==========================================
- Hits 37455 37448 -7
- Misses 6945 6957 +12
+ Partials 2756 2754 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
commented
Oct 29, 2025
|
|
||
| runErrCh := make(chan error, 1) | ||
| go func() { | ||
| require.NoError(t, srv.Run(ctx)) |
Contributor
Author
There was a problem hiding this comment.
I checked to make sure that this test still runs, and it appears to.
Contributor
There was a problem hiding this comment.
what do you mean by that? why would this test not be running?
Comment on lines
-1356
to
+1357
| if fd.Kind() == protoreflect.MessageKind { | ||
| if fd.IsList() { | ||
| l := v.List() | ||
| for i := 0; i < l.Len(); i++ { | ||
| filterSourcePositions(l.Get(i).Message()) | ||
| } | ||
| } else if fd.IsMap() { | ||
| m := v.Map() | ||
| m.Range(func(k protoreflect.MapKey, v protoreflect.Value) bool { | ||
| filterSourcePositions(v.Message()) | ||
| return true | ||
| }) | ||
| switch { | ||
| case fd.Kind() == protoreflect.MessageKind && fd.IsList(): |
Contributor
Author
There was a problem hiding this comment.
This satisfies the linter but also reads a little weird to me - I'm happy to try for a refactor if desired.
miparnisari
approved these changes
Oct 30, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
Co-authored-by: James Thomas <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
… the test function (testifylint)
…th `cfg.MaxOpenConns /= 2` (gocritic)
tstirrat15
force-pushed
the
lint-fixes-part-12
branch
from
469bc3e to
b0ca9c1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of parting out #2455
Description
This is the last component of #2455, with the exception of enabling the linters and fixing the garbage collection test. We're getting very close.
Changes
See comments
Testing
Review. See that tests pass.