fix spanner metrics regression #2329
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
vroldanbet
force-pushed
the
spanner-metrics-regression
branch
from
3c7cba0 to
8e8dc92
Compare
recent changes mean client-side spanner metrics are no longer exposed the prometheus scrape endpoint. The SDK has deprecated OpenCensus support, which was wired into the prometheus endpoint, in favour of OpenTelemetry. This was reflected in a recent SpiceDB change, which made the otel approach the default, and as a consequence all prometheus metrics disappeared. This commit adds the prometheus exporter as a OpenTelemetry MetricsResolver, to add some the metrics back. The naming convention has changed, and I'm not aware of a way around that. Also client-side latency metrics are not supported via the opentelemetry integration. See https://cloud.google.com/spanner/docs/capture-custom-metrics-opentelemetry#capture-client-round-trip-latency Instead they now have to be manually instrumented.
tstirrat15
force-pushed
the
spanner-metrics-regression
branch
from
8e8dc92 to
5af1197
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
==========================================
- Coverage 77.01% 76.94% -0.06%
==========================================
Files 462 462
Lines 49121 49142 +21
==========================================
- Hits 37825 37808 -17
- Misses 8509 8544 +35
- Partials 2787 2790 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent changes mean client-side spanner metrics
are no longer exposed the prometheus scrape endpoint.
The SDK has deprecated OpenCensus support, which was wired into the prometheus endpoint, in favour of OpenTelemetry. This was reflected in a recent SpiceDB change, which made the otel approach the default, and as a consequence all prometheus metrics disappeared.
This commit adds the prometheus exporter as a OpenTelemetry MetricsResolver, to add some the metrics back. The naming convention has changed, and I'm not aware of a way around that.
Also client-side latency metrics are not supported via the opentelemetry integration. See https://cloud.google.com/spanner/docs/capture-custom-metrics-opentelemetry#capture-client-round-trip-latency Instead they now have to be manually instrumented.