fix: case insensitive arguments (#9)

The spec clearly expects most values to be case-sensitive especially scopes.

Author: james-d-elliott

arguments.go

@@ -3,25 +3,39 @@
 
 package oauth2
 
-import (
-	"strings"
-)
-
 type Arguments []string
 
-// Matches performs an case-insensitive, out-of-order check that the items
+// Matches performs an case-sensitive, out-of-order check that the items
+// provided exist and equal all of the args in arguments.
+func (r Arguments) Matches(items ...string) bool {
+	if len(r) != len(items) {
+		return false
+	}
+
+	found := make(map[string]bool)
+	for _, item := range items {
+		if !StringInSlice(item, r) {
+			return false
+		}
+		found[item] = true
+	}
+
+	return len(found) == len(r)
+}
+
+// MatchesFold performs an case-insensitive, out-of-order check that the items
 // provided exist and equal all of the args in arguments.
 // Note:
 //   - Providing a list that includes duplicate string-case items will return not
 //     matched.
-func (r Arguments) Matches(items ...string) bool {
+func (r Arguments) MatchesFold(items ...string) bool {
 	if len(r) != len(items) {
 		return false
 	}
 
 	found := make(map[string]bool)
 	for _, item := range items {
-		if !StringInSlice(item, r) {
+		if !StringInSliceFold(item, r) {
 			return false
 		}
 		found[item] = true
@@ -30,7 +44,7 @@ func (r Arguments) Matches(items ...string) bool {
 	return len(found) == len(r)
 }
 
-// Has checks, in a case-insensitive manner, that all of the items
+// Has checks, in a case-sensitive manner, that all of the items
 // provided exists in arguments.
 func (r Arguments) Has(items ...string) bool {
 	for _, item := range items {
@@ -42,7 +56,19 @@ func (r Arguments) Has(items ...string) bool {
 	return true
 }
 
-// HasOneOf checks, in a case-insensitive manner, that one of the items
+// HasFold checks, in a case-insensitive manner, that all of the items
+// provided exists in arguments.
+func (r Arguments) HasFold(items ...string) bool {
+	for _, item := range items {
+		if !StringInSliceFold(item, r) {
+			return false
+		}
+	}
+
+	return true
+}
+
+// HasOneOf checks, in a case-sensitive manner, that one of the items
 // provided exists in arguments.
 func (r Arguments) HasOneOf(items ...string) bool {
 	for _, item := range items {
@@ -54,9 +80,16 @@ func (r Arguments) HasOneOf(items ...string) bool {
 	return false
 }
 
-// Deprecated: Use ExactOne, Matches or MatchesExact
-func (r Arguments) Exact(name string) bool {
-	return name == strings.Join(r, " ")
+// HasOneOfFold checks, in a case-sensitive manner, that one of the items
+// provided exists in arguments.
+func (r Arguments) HasOneOfFold(items ...string) bool {
+	for _, item := range items {
+		if StringInSliceFold(item, r) {
+			return true
+		}
+	}
+
+	return false
 }
 
 // ExactOne checks, by string case, that a single argument equals the provided

arguments_test.go

@@ -43,21 +43,6 @@ var exactTests = []exactTestCase{
 	},
 }
 
-func TestArgumentsExact(t *testing.T) {
-	testCases := append(exactTests, []exactTestCase{
-		{
-			args:   Arguments{"foo", "bar"},
-			exact:  "foo bar",
-			expect: true,
-		},
-	}...)
-
-	for k, c := range testCases {
-		assert.Equal(t, c.expect, c.args.Exact(c.exact), "%d", k)
-		t.Logf("Passed test case %d", k)
-	}
-}
-
 func TestArgumentsExactOne(t *testing.T) {
 	testCases := append(exactTests, []exactTestCase{
 		{
@@ -219,11 +204,11 @@ func TestArgumentsMatches(t *testing.T) {
 			is:     []string{"bar", "foo"},
 			expect: true,
 		},
-		// should allow case-insensitive matching.
+		// should not allow case-insensitive matching.
 		{
 			args:   Arguments{"fOo", "bar"},
 			is:     []string{"foo", "BaR"},
-			expect: true,
+			expect: false,
 		},
 		// should return non-matching if duplicate items exist.
 		{

helper.go

@@ -10,6 +10,16 @@ import (
 
 // StringInSlice returns true if needle exists in haystack
 func StringInSlice(needle string, haystack []string) bool {
+	for _, b := range haystack {
+		if b == needle {
+			return true
+		}
+	}
+	return false
+}
+
+// StringInSliceFold returns true if needle exists in haystack (case-insensitive).
+func StringInSliceFold(needle string, haystack []string) bool {
 	for _, b := range haystack {
 		if strings.EqualFold(b, needle) {
 			return true