Skip to content

Conversation

@evansims
Copy link
Contributor

Changes

This pull request updates our continuous integration workflows.

codeql.yml

  • Updated name to be consistent with other security scan workflows and repository migrations (clearer for branch protection filtering.)

snyk.yml

  • Specify Python 3.7+ as the runtime for dependency installs during the security scan.
  • Add support for uploading scan results to GitHub Code Scanning.

References

Updates based on internal feedback and conversations.

Testing

This pull request applies improvements to the continuous integration testing for the repository but does not add additional unit tests.

Checklist

@evansims evansims added the review:tiny Tiny review label Aug 29, 2023
@evansims evansims temporarily deployed to internal August 29, 2023 17:38 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 29, 2023 17:38 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 29, 2023 17:38 — with GitHub Actions Inactive
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@evansims evansims temporarily deployed to internal August 29, 2023 17:56 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 29, 2023 17:56 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 29, 2023 17:56 — with GitHub Actions Inactive
@evansims
Copy link
Contributor Author

Note that the current Snyk job will be marked as failing until this is merged. We can force merge after approval to resolve future runs.

@evansims evansims marked this pull request as ready for review August 29, 2023 17:57
@evansims evansims requested a review from a team as a code owner August 29, 2023 17:57
@evansims evansims enabled auto-merge August 29, 2023 17:59
@evansims evansims requested a review from adamjmcgrath August 29, 2023 17:59
@adamjmcgrath adamjmcgrath disabled auto-merge August 30, 2023 12:31
@adamjmcgrath adamjmcgrath merged commit cd25003 into master Aug 30, 2023
@adamjmcgrath adamjmcgrath deleted the test/ci-workflow-improvements branch August 30, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:tiny Tiny review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants