Fix linting errors

Author: Polleps

browser/create-template/src/createOutputFolder.ts

@@ -17,7 +17,7 @@ export async function createOutputFolder(outputDir: string): Promise<void> {
 
   try {
     fs.mkdirSync(outputDir);
-  } catch (error) {
+  } catch (e) {
     console.error(`Failed to create directory: ${outputDir}`);
     process.exit(1);
   }

browser/create-template/src/index.ts

@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-/* eslint-disable no-console */
 import path from 'node:path';
 import { parseArgs } from 'node:util';
 import { copyTemplate } from './copyTemplate.js';

browser/data-browser/.prettierignore

@@ -0,0 +1 @@
+/src/locales/**

browser/data-browser/src/chunks/CodeEditor/AsyncJSONEditor.tsx

@@ -56,7 +56,7 @@ const AsyncJSONEditor: React.FC<JSONEditorProps> = ({
   );
 
   // Wrap jsonParseLinter so we can tap into diagnostics
-  const validationLinter = useCallback(() => {
+  const validationLinter = useMemo(() => {
     const delegate = jsonParseLinter();
 
     return (view: EditorView) => {
@@ -85,8 +85,7 @@ const AsyncJSONEditor: React.FC<JSONEditorProps> = ({
   }, [onValidationChange, required]);
 
   const extensions = useMemo(
-    // eslint-disable-next-line react-hooks/react-compiler
-    () => [json(), linter(validationLinter())],
+    () => [json(), linter(validationLinter)],
     [validationLinter],
   );
 

browser/data-browser/src/chunks/CurrencyPicker/CurrencyPicker.tsx

@@ -35,7 +35,7 @@ const CurrencyPicker: FC<CurrencyPickerProps> = ({ resource }) => {
     }
 
     // We only want to run this effect once. Maybe we should find a better way to do this.
-    // eslint-disable-next-line react-hooks/react-compiler, react-hooks/exhaustive-deps
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   return (

browser/data-browser/src/chunks/RTE/ResourceExtension/ResourceNode.module.css

@@ -8,11 +8,11 @@
 
   &:has(.wideNode) {
     width: 1100px;
-      margin-left: -150px;
+    margin-left: -150px;
 
-      @container (max-width: 1100px) {
-        width: 100%;
-        margin-left: 0;
-      }
+    @container (max-width: 1100px) {
+      width: 100%;
+      margin-left: 0;
+    }
   }
 }

browser/data-browser/src/components/Button.tsx

@@ -43,7 +43,6 @@ const getButtonComp = ({ clean, icon, subtle, alert }: ButtonProps) => {
   }
 
   if (clean) {
-    // @ts-ignore
     Comp = ButtonClean;
   }
 
@@ -131,7 +130,6 @@ interface ButtonBarProps {
 }
 
 /** Button inside the navigation bar */
-// eslint-disable-next-line prettier/prettier
 export const ButtonBar = styled(ButtonClean)<ButtonBarProps>`
   padding-right: 0.5rem;
   padding-left: 0.5rem;
@@ -157,7 +155,6 @@ export const ButtonBar = styled(ButtonClean)<ButtonBarProps>`
 `;
 
 /** Button with some optional margins around it */
-// eslint-disable-next-line prettier/prettier
 export const ButtonDefault = styled(ButtonBase)<ButtonPropsStyled>`
   --button-bg-color: ${p => p.theme.colors.main};
   --button-bg-color-hover: ${p => p.theme.colors.mainLight};

browser/data-browser/src/components/Dialog/index.tsx

@@ -139,15 +139,13 @@ const InnerDialog: React.FC<React.PropsWithChildren<InternalDialogProps>> = ({
 
     if (show) {
       if (!dialogRef.current.hasAttribute('open'))
-        // @ts-ignore
         dialogRef.current.showModal();
     }
 
     if (dialogRef.current.hasAttribute('data-closing')) {
       // TODO: Use getAnimations() api to wait for the animations to complete instead of a timeout.
       return timeoutEffect(() => {
-        // @ts-ignore
-        dialogRef.current.close();
+        dialogRef.current?.close();
         dialogRef.current?.removeAttribute('data-closing');
         onClosed();
       }, ANIM_MS);

browser/data-browser/src/components/HotKeyWrapper.tsx

@@ -74,7 +74,10 @@ function HotKeysWrapper({ children }: Props): JSX.Element {
     shortcuts.edit,
     e => {
       e.preventDefault();
-      Client.isValidSubject(subject) && navigate(editURL(subject!));
+
+      if (Client.isValidSubject(subject)) {
+        navigate(editURL(subject!));
+      }
     },
     {},
     [subject],
@@ -83,7 +86,10 @@ function HotKeysWrapper({ children }: Props): JSX.Element {
     shortcuts.data,
     e => {
       e.preventDefault();
-      Client.isValidSubject(subject) && navigate(dataURL(subject!));
+
+      if (Client.isValidSubject(subject)) {
+        navigate(dataURL(subject!));
+      }
     },
     {},
     [subject],

browser/data-browser/src/components/Navigation.tsx

@@ -87,7 +87,7 @@ function NavBar(): JSX.Element {
   const isInStandaloneMode = React.useMemo<boolean>(
     () =>
       machesStandalone ||
-      //@ts-ignore
+      // @ts-expect-error standalone is available on the navigator object.
       window.navigator.standalone ||
       document.referrer.includes('android-app://') ||
       isRunningInTauri(),