From 7c57a1ba2def00af2dd8b9cacd89a61accca63d7 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 11 May 2020 09:45:35 -0400 Subject: [PATCH] fixup deletePassword to properly throw an error if service isn't a string --- src/main.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main.cc b/src/main.cc index 33d8170f..6686310e 100644 --- a/src/main.cc +++ b/src/main.cc @@ -69,7 +69,8 @@ Napi::Value GetPassword(const Napi::CallbackInfo& info) { Napi::Value DeletePassword(const Napi::CallbackInfo& info) { Napi::Env env = info.Env(); if (!info[0].IsString()) { - Napi::TypeError::New(env, "Parameter 'service' must be a string"); + Napi::TypeError::New(env, "Parameter 'service' must be a string"). + ThrowAsJavaScriptException(); return env.Null(); }