Skip to content

get correct cwd when treeview is the previousActiveItem#102

Merged
UziTech merged 3 commits into
atom-community:masterfrom
tom-power:treeviewCwd
Nov 4, 2022
Merged

get correct cwd when treeview is the previousActiveItem#102
UziTech merged 3 commits into
atom-community:masterfrom
tom-power:treeviewCwd

Conversation

@tom-power

Copy link
Copy Markdown
Contributor

Identify the Bug

#101

Description of the Change

  • use selectedPath in getInitialCwd when getPath doesn't return anything, which is the case for tree view items

Verification Process

Added tests, used for a while

Release Notes

  • path of terminal opened with atomic-terminal:open now matches the selected project

-->

@UziTech

UziTech commented Oct 29, 2022

Copy link
Copy Markdown
Member

If you want to get the tests passing I can merge this but I don't know if it is worth it since Atom is sunsetting soon

@tom-power

Copy link
Copy Markdown
Contributor Author

sorry, can't think of another way to change these, and yes sunset but it still works :)

@UziTech UziTech merged commit e462b00 into atom-community:master Nov 4, 2022
@UziTech

UziTech commented Nov 4, 2022

Copy link
Copy Markdown
Member

Thanks for fixing this. 💯

@tom-power

Copy link
Copy Markdown
Contributor Author

awesome thank you 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants