Skip to content

Commit 44cab9c

Browse files
vzapolskiycomputersforpeace
authored andcommitted
mtd: lpc32xx_slc: fix warnings caused by enabling unprepared clock
If common clock framework is configured, the driver generates a warning, which is fixed by this change: WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:727 clk_core_enable+0x2c/0xa4() Modules linked in: CPU: 0 PID: 1 Comm: swapper Not tainted 4.3.0-rc2+ torvalds#201 Hardware name: LPC32XX SoC (Flattened Device Tree) Backtrace: [<>] (dump_backtrace) from [<>] (show_stack+0x18/0x1c) [<>] (show_stack) from [<>] (dump_stack+0x20/0x28) [<>] (dump_stack) from [<>] (warn_slowpath_common+0x90/0xb8) [<>] (warn_slowpath_common) from [<>] (warn_slowpath_null+0x24/0x2c) [<>] (warn_slowpath_null) from [<>] (clk_core_enable+0x2c/0xa4) [<>] (clk_core_enable) from [<>] (clk_enable+0x24/0x38) [<>] (clk_enable) from [<>] (lpc32xx_nand_probe+0x290/0x568) [<>] (lpc32xx_nand_probe) from [<>] (platform_drv_probe+0x50/0xa0) [<>] (platform_drv_probe) from [<>] (driver_probe_device+0x18c/0x408) [<>] (driver_probe_device) from [<>] (__driver_attach+0x70/0x94) [<>] (__driver_attach) from [<>] (bus_for_each_dev+0x74/0x98) [<>] (bus_for_each_dev) from [<>] (driver_attach+0x20/0x28) [<>] (driver_attach) from [<>] (bus_add_driver+0x11c/0x248) [<>] (bus_add_driver) from [<>] (driver_register+0xa4/0xe8) [<>] (driver_register) from [<>] (__platform_driver_register+0x50/0x64) [<>] (__platform_driver_register) from [<>] (lpc32xx_nand_driver_init+0x18/0x20) [<>] (lpc32xx_nand_driver_init) from [<>] (do_one_initcall+0x11c/0x1dc) [<>] (do_one_initcall) from [<>] (kernel_init_freeable+0x10c/0x1d4) [<>] (kernel_init_freeable) from [<>] (kernel_init+0x10/0xec) [<>] (kernel_init) from [<>] (ret_from_fork+0x14/0x24) Signed-off-by: Vladimir Zapolskiy <[email protected]> Signed-off-by: Brian Norris <[email protected]>
1 parent ff84d2b commit 44cab9c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/mtd/nand/lpc32xx_slc.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -814,7 +814,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
814814
res = -ENOENT;
815815
goto err_exit1;
816816
}
817-
clk_enable(host->clk);
817+
clk_prepare_enable(host->clk);
818818

819819
/* Set NAND IO addresses and command/ready functions */
820820
chip->IO_ADDR_R = SLC_DATA(host->io_base);
@@ -919,7 +919,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
919919
err_exit3:
920920
dma_release_channel(host->dma_chan);
921921
err_exit2:
922-
clk_disable(host->clk);
922+
clk_disable_unprepare(host->clk);
923923
err_exit1:
924924
lpc32xx_wp_enable(host);
925925

@@ -943,7 +943,7 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
943943
tmp &= ~SLCCFG_CE_LOW;
944944
writel(tmp, SLC_CTRL(host->io_base));
945945

946-
clk_disable(host->clk);
946+
clk_disable_unprepare(host->clk);
947947
lpc32xx_wp_enable(host);
948948

949949
return 0;
@@ -955,7 +955,7 @@ static int lpc32xx_nand_resume(struct platform_device *pdev)
955955
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
956956

957957
/* Re-enable NAND clock */
958-
clk_enable(host->clk);
958+
clk_prepare_enable(host->clk);
959959

960960
/* Fresh init of NAND controller */
961961
lpc32xx_nand_setup(host);
@@ -980,7 +980,7 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
980980
lpc32xx_wp_enable(host);
981981

982982
/* Disable clock */
983-
clk_disable(host->clk);
983+
clk_disable_unprepare(host->clk);
984984

985985
return 0;
986986
}

0 commit comments

Comments
 (0)