Skip to content

Commit 42ce2be

Browse files
committed
Fix BuildStartedActivity overload
1 parent 1a60596 commit 42ce2be

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

src/Proto.OpenTelemetry/OpenTelemetryHelpers.cs

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,17 @@ public static void DefaultSetupActivity(Activity _, object __)
2727
)
2828
{
2929
var messageType = message.GetMessageTypeName();
30-
return BuildStartedActivity(parent, source, verb, messageType, activitySetup, activityKind);
30+
31+
var name = $"Proto {source}.{verb} {messageType}";
32+
var tags = new[] { new KeyValuePair<string, object?>(ProtoTags.MessageType, messageType) };
33+
var activity = ActivitySource.StartActivity(name, activityKind, parent, tags);
34+
35+
if (activity is not null)
36+
{
37+
activitySetup(activity, message);
38+
}
39+
40+
return activity;
3141
}
3242

3343
[MethodImpl(MethodImplOptions.AggressiveInlining)]
@@ -94,4 +104,4 @@ public static PropagationContext ExtractPropagationContext(this MessageHeader he
94104

95105
private static void AddHeader(List<KeyValuePair<string, string>> list, string key, string value) =>
96106
list.Add(new KeyValuePair<string, string>(key, value));
97-
}
107+
}

0 commit comments

Comments
 (0)