Skip to content

Commit 7fa8ba8

Browse files
authored
Use a more stable sorting for the region metadata (#2014)
Sorting region groups based on the numer of regions in the group generates some unnecessary changes during SDK updates when adding a new region in a group.
1 parent c77bea8 commit 7fa8ba8

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
### Changed
1717

1818
- Apply new CodingStandard from latest php-cs-fixer.
19+
- Use a more stable sorting for the list of generated region metadata
1920

2021
## 2.9.0
2122

src/SecretsManagerClient.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,13 @@ protected function getEndpointMetadata(?string $region): array
508508
'signService' => 'secretsmanager',
509509
'signVersions' => ['v4'],
510510
];
511+
case 'eu-isoe-west-1':
512+
return [
513+
'endpoint' => 'https://secretsmanager.eu-isoe-west-1.cloud.adc-e.uk',
514+
'signRegion' => 'eu-isoe-west-1',
515+
'signService' => 'secretsmanager',
516+
'signVersions' => ['v4'],
517+
];
511518
case 'us-iso-east-1':
512519
case 'us-iso-east-1-fips':
513520
case 'us-iso-west-1':
@@ -535,13 +542,6 @@ protected function getEndpointMetadata(?string $region): array
535542
'signService' => 'secretsmanager',
536543
'signVersions' => ['v4'],
537544
];
538-
case 'eu-isoe-west-1':
539-
return [
540-
'endpoint' => 'https://secretsmanager.eu-isoe-west-1.cloud.adc-e.uk',
541-
'signRegion' => 'eu-isoe-west-1',
542-
'signService' => 'secretsmanager',
543-
'signVersions' => ['v4'],
544-
];
545545
}
546546

547547
return [

0 commit comments

Comments
 (0)