Skip to content

Commit 4d3d834

Browse files
HDDS-12650. Added logs to SnapshotDeletingService to indicate skipped snapshots. (apache#8123)
1 parent 7524736 commit 4d3d834

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,8 @@ public BackgroundTaskResult call() throws InterruptedException {
165165
while (iterator.hasNext() && snapshotLimit > 0 && remaining > 0) {
166166
SnapshotInfo snapInfo = SnapshotUtils.getSnapshotInfo(ozoneManager, chainManager, iterator.next());
167167
if (shouldIgnoreSnapshot(snapInfo)) {
168+
LOG.debug("Skipping Snapshot Deletion processing because " +
169+
"the snapshot is active or DB changes are not flushed: {}", snapInfo.getTableKey());
168170
continue;
169171
}
170172
LOG.info("Started Snapshot Deletion Processing for snapshot : {}", snapInfo.getTableKey());
@@ -173,13 +175,19 @@ public BackgroundTaskResult call() throws InterruptedException {
173175
// another.
174176
if (nextSnapshot != null &&
175177
nextSnapshot.getSnapshotStatus() != SnapshotInfo.SnapshotStatus.SNAPSHOT_ACTIVE) {
178+
LOG.info("Skipping Snapshot Deletion processing for : {} because the next snapshot is DELETED.",
179+
snapInfo.getTableKey());
176180
continue;
177181
}
178182

179183
// nextSnapshot = null means entries would be moved to AOS.
180184
if (nextSnapshot == null) {
185+
LOG.info("Snapshot: {} entries will be moved to AOS.", snapInfo.getTableKey());
181186
waitForKeyDeletingService();
182187
waitForDirDeletingService();
188+
} else {
189+
LOG.info("Snapshot: {} entries will be moved to next active snapshot: {}",
190+
snapInfo.getTableKey(), nextSnapshot.getTableKey());
183191
}
184192
try (ReferenceCounted<OmSnapshot> snapshot = omSnapshotManager.getSnapshot(
185193
snapInfo.getVolumeName(), snapInfo.getBucketName(), snapInfo.getName())) {

0 commit comments

Comments
 (0)