Turn reqwest_blocking_get into download_to_disk

Author: fasterthanlime

crates/uv/tests/common/mod.rs

@@ -14,11 +14,13 @@ use assert_fs::assert::PathAssert;
 use assert_fs::fixture::{ChildPath, PathChild, PathCopy, PathCreateDir, SymlinkToFile};
 use base64::{prelude::BASE64_STANDARD as base64, Engine};
 use etcetera::BaseStrategy;
+use futures::StreamExt;
 use indoc::formatdoc;
 use itertools::Itertools;
 use predicates::prelude::predicate;
 use regex::Regex;
 
+use tokio::io::AsyncWriteExt;
 use uv_cache::Cache;
 use uv_fs::Simplified;
 use uv_python::managed::ManagedPythonInstallations;
@@ -1282,7 +1284,7 @@ pub fn decode_token(content: &[&str]) -> String {
 /// Simulates `reqwest::blocking::get` but returns bytes directly, and disables
 /// certificate verification, passing through the `BaseClient`
 #[tokio::main(flavor = "current_thread")]
-pub async fn reqwest_blocking_get(url: &str) -> Vec<u8> {
+pub async fn download_to_disk(url: &str, path: &Path) {
     let trusted_hosts: Vec<_> = std::env::var("UV_INSECURE_HOST")
         .unwrap_or_default()
         .split(' ')
@@ -1295,7 +1297,13 @@ pub async fn reqwest_blocking_get(url: &str) -> Vec<u8> {
     let url: reqwest::Url = url.parse().unwrap();
     let client = client.for_host(&url);
     let response = client.request(http::Method::GET, url).send().await.unwrap();
-    response.bytes().await.unwrap().to_vec()
+
+    let mut file = tokio::fs::File::create(path).await.unwrap();
+    let mut stream = response.bytes_stream();
+    while let Some(chunk) = stream.next().await {
+        file.write_all(&chunk.unwrap()).await.unwrap();
+    }
+    file.sync_all().await.unwrap();
 }
 
 /// Utility macro to return the name of the current function.

crates/uv/tests/lock.rs

@@ -8,7 +8,7 @@ use insta::assert_snapshot;
 use std::io::BufReader;
 use url::Url;
 
-use common::{reqwest_blocking_get, uv_snapshot, TestContext};
+use common::{download_to_disk, uv_snapshot, TestContext};
 use uv_fs::Simplified;
 
 use crate::common::{build_vendor_links_url, decode_token, packse_index_url};
@@ -7881,11 +7881,11 @@ fn lock_sources_archive() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download the source.
-    let bytes =
-        reqwest_blocking_get("https://github.com/user-attachments/files/16592193/workspace.zip");
     let workspace_archive = context.temp_dir.child("workspace.zip");
-    let mut workspace_archive_file = fs_err::File::create(&*workspace_archive)?;
-    std::io::copy(&mut &bytes[..], &mut workspace_archive_file)?;
+    download_to_disk(
+        "https://github.com/user-attachments/files/16592193/workspace.zip",
+        &workspace_archive,
+    );
 
     let pyproject_toml = context.temp_dir.child("pyproject.toml");
     pyproject_toml.write_str(&formatdoc! {
@@ -8020,11 +8020,11 @@ fn lock_sources_source_tree() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download the source.
-    let bytes =
-        reqwest_blocking_get("https://github.com/user-attachments/files/16592193/workspace.zip");
     let workspace_archive = context.temp_dir.child("workspace.zip");
-    let mut workspace_archive_file = fs_err::File::create(&*workspace_archive)?;
-    std::io::copy(&mut &bytes[..], &mut workspace_archive_file)?;
+    download_to_disk(
+        "https://github.com/user-attachments/files/16592193/workspace.zip",
+        &workspace_archive,
+    );
 
     // Unzip the file.
     let file = fs_err::File::open(&*workspace_archive)?;

crates/uv/tests/pip_compile.rs

@@ -10,7 +10,7 @@ use assert_fs::prelude::*;
 use indoc::indoc;
 use url::Url;
 
-use common::{reqwest_blocking_get, uv_snapshot, TestContext};
+use common::{download_to_disk, uv_snapshot, TestContext};
 use uv_fs::Simplified;
 
 mod common;
@@ -2596,10 +2596,11 @@ fn compile_wheel_path_dependency() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl");
     let flask_wheel = context.temp_dir.child("flask-3.0.0-py3-none-any.whl");
-    let mut flask_wheel_file = fs::File::create(&flask_wheel)?;
-    std::io::copy(&mut &bytes[..], &mut flask_wheel_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl",
+        &flask_wheel,
+    );
 
     let requirements_in = context.temp_dir.child("requirements.in");
     requirements_in.write_str(&format!(
@@ -2846,10 +2847,11 @@ fn compile_wheel_path_dependency() -> Result<()> {
 fn compile_source_distribution_path_dependency() -> Result<()> {
     let context = TestContext::new("3.12");
     // Download a source distribution.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/d8/09/c1a7354d3925a3c6c8cfdebf4245bae67d633ffda1ba415add06ffc839c5/flask-3.0.0.tar.gz");
     let flask_wheel = context.temp_dir.child("flask-3.0.0.tar.gz");
-    let mut flask_wheel_file = std::fs::File::create(&flask_wheel)?;
-    std::io::copy(&mut &bytes[..], &mut flask_wheel_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/d8/09/c1a7354d3925a3c6c8cfdebf4245bae67d633ffda1ba415add06ffc839c5/flask-3.0.0.tar.gz",
+        &flask_wheel,
+    );
 
     let requirements_in = context.temp_dir.child("requirements.in");
     requirements_in.write_str(&format!(
@@ -3521,10 +3523,11 @@ fn preserve_url() -> Result<()> {
 fn preserve_project_root() -> Result<()> {
     let context = TestContext::new("3.12");
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl");
     let flask_wheel = context.temp_dir.child("flask-3.0.0-py3-none-any.whl");
-    let mut flask_wheel_file = std::fs::File::create(flask_wheel)?;
-    std::io::copy(&mut &bytes[..], &mut flask_wheel_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl",
+        &flask_wheel,
+    );
 
     let requirements_in = context.temp_dir.child("requirements.in");
     requirements_in.write_str("flask @ file://${PROJECT_ROOT}/flask-3.0.0-py3-none-any.whl")?;
@@ -3674,10 +3677,11 @@ fn error_missing_unnamed_env_var() -> Result<()> {
 fn respect_file_env_var() -> Result<()> {
     let context = TestContext::new("3.12");
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl");
     let flask_wheel = context.temp_dir.child("flask-3.0.0-py3-none-any.whl");
-    let mut flask_wheel_file = std::fs::File::create(flask_wheel)?;
-    std::io::copy(&mut &bytes[..], &mut flask_wheel_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/36/42/015c23096649b908c809c69388a805a571a3bea44362fe87e33fc3afa01f/flask-3.0.0-py3-none-any.whl",
+        &flask_wheel,
+    );
 
     let requirements_in = context.temp_dir.child("requirements.in");
     requirements_in.write_str("flask @ ${FILE_PATH}")?;

crates/uv/tests/pip_sync.rs

@@ -13,7 +13,7 @@ use indoc::indoc;
 use predicates::Predicate;
 use url::Url;
 
-use common::{reqwest_blocking_get, uv_snapshot, venv_to_interpreter};
+use common::{download_to_disk, uv_snapshot, venv_to_interpreter};
 use uv_fs::Simplified;
 
 use crate::common::{copy_dir_all, site_packages_path, TestContext};
@@ -1073,10 +1073,8 @@ fn install_local_wheel() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let response = reqwest_blocking_get("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl");
     let archive = context.temp_dir.child("tomli-2.0.1-py3-none-any.whl");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &response[..], &mut archive_file)?;
+    download_to_disk("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl", &archive);
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     requirements_txt.write_str(&format!(
@@ -1212,10 +1210,8 @@ fn mismatched_version() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl");
     let archive = context.temp_dir.child("tomli-3.7.2-py3-none-any.whl");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl", &archive);
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     requirements_txt.write_str(&format!(
@@ -1247,10 +1243,11 @@ fn mismatched_name() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl");
     let archive = context.temp_dir.child("foo-2.0.1-py3-none-any.whl");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl",
+        &archive,
+    );
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     requirements_txt.write_str(&format!(
@@ -1283,10 +1280,11 @@ fn install_local_source_distribution() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a source distribution.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/b0/b4/bc2baae3970c282fae6c2cb8e0f179923dceb7eaffb0e76170628f9af97b/wheel-0.42.0.tar.gz");
     let archive = context.temp_dir.child("wheel-0.42.0.tar.gz");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/b0/b4/bc2baae3970c282fae6c2cb8e0f179923dceb7eaffb0e76170628f9af97b/wheel-0.42.0.tar.gz",
+        &archive,
+    );
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     requirements_txt.write_str(&format!(
@@ -1643,10 +1641,11 @@ fn install_path_source_dist_cached() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a source distribution.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/10/1f/57aa4cce1b1abf6b433106676e15f9fa2c92ed2bd4cf77c3b50a9e9ac773/source_distribution-0.0.1.tar.gz");
     let archive = context.temp_dir.child("source_distribution-0.0.1.tar.gz");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/10/1f/57aa4cce1b1abf6b433106676e15f9fa2c92ed2bd4cf77c3b50a9e9ac773/source_distribution-0.0.1.tar.gz",
+        &archive,
+    );
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     requirements_txt.write_str(&format!(
@@ -1738,10 +1737,11 @@ fn install_path_built_dist_cached() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let bytes = reqwest_blocking_get("https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl");
     let archive = context.temp_dir.child("tomli-2.0.1-py3-none-any.whl");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl",
+        &archive,
+    );
 
     let requirements_txt = context.temp_dir.child("requirements.txt");
     let url = Url::from_file_path(archive.path()).unwrap();

crates/uv/tests/show_settings.rs

@@ -3557,12 +3557,12 @@ fn allow_insecure_host() -> anyhow::Result<()> {
             index_strategy: FirstIndex,
             keyring_provider: Disabled,
             allow_insecure_host: [
-                TrustedHost {
+                Host {
                     scheme: None,
                     host: "google.com",
                     port: None,
                 },
-                TrustedHost {
+                Host {
                     scheme: None,
                     host: "example.com",
                     port: None,

crates/uv/tests/sync.rs

@@ -5,7 +5,7 @@ use assert_cmd::prelude::*;
 use assert_fs::{fixture::ChildPath, prelude::*};
 use insta::assert_snapshot;
 
-use common::{reqwest_blocking_get, uv_snapshot, venv_bin_path, TestContext};
+use common::{download_to_disk, uv_snapshot, venv_bin_path, TestContext};
 use predicates::prelude::predicate;
 use tempfile::tempdir_in;
 
@@ -2313,12 +2313,13 @@ fn sync_wheel_path_source_error() -> Result<()> {
     let context = TestContext::new("3.12");
 
     // Download a wheel.
-    let bytes = reqwest_blocking_get( "https://files.pythonhosted.org/packages/08/fd/cc2fedbd887223f9f5d170c96e57cbf655df9831a6546c1727ae13fa977a/cffi-1.17.1-cp310-cp310-macosx_11_0_arm64.whl");
     let archive = context
         .temp_dir
         .child("cffi-1.17.1-cp310-cp310-macosx_11_0_arm64.whl");
-    let mut archive_file = fs_err::File::create(archive.path())?;
-    std::io::copy(&mut &bytes[..], &mut archive_file)?;
+    download_to_disk(
+        "https://files.pythonhosted.org/packages/08/fd/cc2fedbd887223f9f5d170c96e57cbf655df9831a6546c1727ae13fa977a/cffi-1.17.1-cp310-cp310-macosx_11_0_arm64.whl",
+        &archive,
+    );
 
     let pyproject_toml = context.temp_dir.child("pyproject.toml");
     pyproject_toml.write_str(