Skip to content

Commit 470ad45

Browse files
konstincharliermarsh
authored andcommitted
Remove allow insecure host from ResolverInstallerArgs
1 parent cf3aed5 commit 470ad45

3 files changed

Lines changed: 2 additions & 35 deletions

File tree

crates/uv-cli/src/lib.rs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4375,26 +4375,6 @@ pub struct ResolverInstallerArgs {
43754375
)]
43764376
pub keyring_provider: Option<KeyringProviderType>,
43774377

4378-
/// Allow insecure connections to a host.
4379-
///
4380-
/// Can be provided multiple times.
4381-
///
4382-
/// Expects to receive either a hostname (e.g., `localhost`), a host-port pair (e.g.,
4383-
/// `localhost:8080`), or a URL (e.g., `https://localhost`).
4384-
///
4385-
/// WARNING: Hosts included in this list will not be verified against the system's certificate
4386-
/// store. Only use `--allow-insecure-host` in a secure network with verified sources, as it
4387-
/// bypasses SSL verification and could expose you to MITM attacks.
4388-
#[arg(
4389-
long,
4390-
alias = "trusted-host",
4391-
env = EnvVars::UV_INSECURE_HOST,
4392-
value_delimiter = ' ',
4393-
value_parser = parse_insecure_host,
4394-
help_heading = "Index options"
4395-
)]
4396-
pub allow_insecure_host: Option<Vec<Maybe<TrustedHost>>>,
4397-
43984378
/// The strategy to use when selecting between the different compatible versions for a given
43994379
/// package requirement.
44004380
///

crates/uv-cli/src/options.rs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ impl From<ResolverInstallerArgs> for PipOptions {
123123
reinstall_package,
124124
index_strategy,
125125
keyring_provider,
126-
allow_insecure_host,
127126
resolution,
128127
prerelease,
129128
pre,
@@ -145,12 +144,7 @@ impl From<ResolverInstallerArgs> for PipOptions {
145144
reinstall_package: Some(reinstall_package),
146145
index_strategy,
147146
keyring_provider,
148-
allow_insecure_host: allow_insecure_host.map(|allow_insecure_host| {
149-
allow_insecure_host
150-
.into_iter()
151-
.filter_map(Maybe::into_option)
152-
.collect()
153-
}),
147+
allow_insecure_host: None,
154148
resolution,
155149
prerelease: if pre {
156150
Some(PrereleaseMode::Allow)
@@ -310,7 +304,6 @@ pub fn resolver_installer_options(
310304
reinstall_package,
311305
index_strategy,
312306
keyring_provider,
313-
allow_insecure_host,
314307
resolution,
315308
prerelease,
316309
pre,
@@ -376,12 +369,7 @@ pub fn resolver_installer_options(
376369
},
377370
index_strategy,
378371
keyring_provider,
379-
allow_insecure_host: allow_insecure_host.map(|allow_insecure_host| {
380-
allow_insecure_host
381-
.into_iter()
382-
.filter_map(Maybe::into_option)
383-
.collect()
384-
}),
372+
allow_insecure_host: None,
385373
resolution,
386374
prerelease: if pre {
387375
Some(PrereleaseMode::Allow)

docs/reference/settings.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ bypasses SSL verification and could expose you to MITM attacks.
329329
=== "uv.toml"
330330

331331
```toml
332-
333332
allow-insecure-host = ["localhost:8080"]
334333
```
335334

0 commit comments

Comments
 (0)